GNOME Bugzilla – Bug 309253
GST_DEBUG_FUNCPTR macro does illegal casting from function pointer to void pointer
Last modified: 2005-07-20 16:20:31 UTC
the GST_DEBUG_FUNCPTR macro is defined as: gstinfo.h:#define GST_DEBUG_FUNCPTR(ptr) (_gst_debug_register_funcptr((void *)(ptr), #ptr) , ptr) which include a cast from a function pointer to a void pointer. this is illegal, and gcc 3.4 give the following warning about it: warning: ISO C forbids conversion of function pointer to object pointer type (see the downstream bug at the LiveSupport project bug database at http://bugs.campware.org/view.php?id=1216)
Hm, that doesn't look good indeed. The campware bugzilla is not accessible for non-subscribers, btw (it'll show the log-in page). Afaik, glib uses function-type casts, e.g. something like this is acceptable: typedef void (*GstDebugFunctionPtr) (void); #define GST_DEBUG_FUNCPTR(func) \ (_gst_debug_register_funcptr((GstDebugFuncPtr)func, #func), func) void _gst_debug_register_funcptr(GstDebugFuncPtr func, const gchar *name); Note that this is in fact an API change, since _register_funcptr() used to return a void* containing the function itself (which is silly). I'm not so sure if we should change API (my brain tells me it's OK, my guts tells me we shouldn't). For 0.9, we should definitely change this, though.
Applied a fix for this (or so I believe :) ). 0.9-only, since it's an API change...