After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 309162 - Renaming icons should apply with click also
Renaming icons should apply with click also
Status: RESOLVED FIXED
Product: nautilus
Classification: Core
Component: File and Folder Operations
3.0.x
Other All
: Normal minor
: ---
Assigned To: Nautilus Maintainers
Nautilus Maintainers
: 327989 340150 348820 362205 536806 556830 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2005-06-28 04:19 UTC by Marc E.
Modified: 2016-12-02 17:53 UTC
See Also:
GNOME target: ---
GNOME version: 2.91/3.0

Attachments
Proposed patch (881 bytes, patch)
2005-09-10 22:27 UTC, Christian Neumair 		needs-work Details | Review

Description Marc E. 2005-06-28 04:19:31 UTC 
Please describe the problem:
When renaming an object on the desktop, and not pressing enter after doing so,
if you try to move the object without clicking first, just dragging it, it
displays the original name, and does so until its released.

Steps to reproduce:


Actual results:


Expected results:


Does this happen every time?


Other information:
Comment 1 Christian Neumair 2005-06-28 11:50:00 UTC 
Thanks for your bug report! I can still reproduce this with Nautilus 2.11.
Comment 2 Christian Neumair 2005-09-10 22:27:10 UTC 
Created attachment 52068 [details] [review]
Proposed patch

I've also submitted this patch to the nautilus mailing list [1] for review.

[1] http://mail.gnome.org/archives/nautilus-list/2005-September/msg00097.html
Comment 3 Christian Neumair 2005-09-10 22:28:00 UTC 
Updating bug information.
Comment 4 Martin Wehner 2005-12-16 22:47:16 UTC 
Comment on attachment 52068 [details] [review]
Proposed patch

Alex comment from the list:

This breaks the initial intent of the code, which is that if you click
on the icon you're renaming (e.g. if you miss when selecting in the
rename widget) you exit rename mode. 

Of course, its hard to get the rename done before creating the dnd icon
if we delay renaming until the motion event that starts the dnd since
the rename is asynchronous. In fact, even with your patch this is broken
if you drag quickly enough.
Comment 5 Martin Wehner 2005-12-16 22:50:26 UTC 
And Manny said like:
> Hrm I never miss widgets I want to click. Is that a huge issue for
> visually impaired people? If it is, we should probably do the same for
> the lower end of the entry as well. I fail to see why one should click
> the middle of the icon while renaming to select anything.

So spoke Alex:
I'm not sure why it was done like that, but it my main concern is that
your patch doesn't really fix the problem fully.
Comment 6 Cosimo Cecchi 2007-12-27 14:48:08 UTC 
*** Bug 348820 has been marked as a duplicate of this bug. ***
Comment 7 Cosimo Cecchi 2008-01-12 12:20:23 UTC 
*** Bug 362205 has been marked as a duplicate of this bug. ***
Comment 8 Cosimo Cecchi 2008-01-20 01:09:43 UTC 
*** Bug 327989 has been marked as a duplicate of this bug. ***
Comment 9 Cosimo Cecchi 2008-06-05 13:49:32 UTC 
*** Bug 536806 has been marked as a duplicate of this bug. ***
Comment 10 Cosimo Cecchi 2008-06-05 13:51:52 UTC 
Setting patch as "needs-work" as for comment #5.
Comment 11 Cosimo Cecchi 2008-10-18 14:03:57 UTC 
*** Bug 556830 has been marked as a duplicate of this bug. ***
Comment 12 A. Walton 2009-06-19 14:19:16 UTC 
*** Bug 340150 has been marked as a duplicate of this bug. ***
Comment 13 Cosimo Cecchi 2011-04-21 13:24:06 UTC 
*** Bug 648239 has been marked as a duplicate of this bug. ***
Comment 14 Alexandre Franke 2016-12-02 17:53:50 UTC 
The behaviour with the new rename dialog is sane, if you click somewhere else you exit the dialog.