After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 309112 - Empty channels in compose plug-in
Empty channels in compose plug-in
Status: RESOLVED FIXED
Product: GIMP
Classification: Other
Component: Plugins
2.2.x
Other All
: High enhancement
: 2.4
Assigned To: GIMP Bugs
GIMP Bugs
Depends on:
Blocks:
 
 
Reported: 2005-06-27 08:38 UTC by Dan
Modified: 2008-01-15 12:57 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
And the patch ... (24.35 KB, patch)
2005-09-14 07:07 UTC, Sylvain FORET
none Details | Review
A small improvement (26.22 KB, patch)
2005-09-20 10:04 UTC, Sylvain FORET
committed Details | Review

Description Dan 2005-06-27 08:38:04 UTC
Using function tool: "Image"->"Mode"->"Compose"

If you compose eg to an RGB image and you only have two images channels that you
want to compose(eg. Green and Red channels only).

It would be very helpful if in the "channel representations" list where you
select which file to go into which channel, if there were additional channel
options to fill the remaining empty channel(s) (eg blue) with either the
foreground or background or white or black colours. 

This is a very common operation in the microscopy field, where you frequently
work with RGB images but only want to compose two channels.
Comment 1 Sven Neumann 2005-06-28 09:34:07 UTC
Sounds like a useful feature and it is probably easy to implement. Adding the
gnome-love keyword.
Comment 2 Sylvain FORET 2005-09-14 07:05:45 UTC
Here is a patch that adds this functionality.
Channels can now be replaced with a 'Maks value', that can be either black or
white or anything in between.
At least one image or drawable still has to be provided though.
Comment 3 Sylvain FORET 2005-09-14 07:07:58 UTC
Created attachment 52207 [details] [review]
And the patch ...
Comment 4 Michael Natterer 2005-09-14 09:29:38 UTC
That patch looks excellent :)  (it happens about once in a million
times that a patch follows the coding style so perfectly)

Will look into applying that.
Comment 5 Sylvain FORET 2005-09-20 10:04:06 UTC
Created attachment 52428 [details] [review]
A small improvement

This little improvement over the previous patch warns the user that at least
one image must be selected before the plugin's dialog disapears.
Comment 6 Dan 2005-09-20 11:43:00 UTC
Thankyou for your work. I am not sure what to do with the patch (if anything)
but am happy to wait for a subsequent gimp version with it incorporated. 
Comment 7 Michael Natterer 2005-09-20 12:34:32 UTC
Thanks for the update, applied it to CVS:

2005-09-20  Michael Natterer  <mitch@gimp.org>

	* plug-ins/common/compose.c: applied patch from Sylvain Foret
	which allows to use fixed greyscale values instead of drawables
	for color components. Fixes bug #309112.