GNOME Bugzilla – Bug 309087
artsdsink registers conflicting property "name" which causes breakage
Last modified: 2005-08-07 23:01:32 UTC
Hi, The artsdsink plugin registers the "name" property (presumably to select an output device) with default value NULL. This causes breakage when pipeline are constructed with the artsdsink element in the 0.8.9 series of GStreamer. (gst_*check_uniqueness complains of a duplicate name "(null)" in pipeline) Bye,
Created attachment 48381 [details] [review] fix artsd registering "name"
Isn't it better to rename the property than to remove it?
I forgot to mention I grepped on "name" to check whether it was in use, and couldn't find any occurrence beside the registration, hence the removal. It's probably best if you check too so that we don't introduce more breakage if it is in use somewhere.
FYI, I get segfaults in libarts, as well as another Debian user with the patch. I suspect this is in no way connected to the patch, but related to the build environment and that the user would have the crash with a self-rebuilt plugins without the patch. This is terribly visible in: http://bugs.kde.org/show_bug.cgi?id=62603 And in the "Important bugs - forwarded to upstream software authors (7 bugs)" section at: http://bugs.debian.org/cgi-bin/pkgreport.cgi?src=arts I'll confirm this with the reporter though.
Fixed differently, by renaming the property.
Thanks, I synced with: http://cvs.freedesktop.org/gstreamer/gst-plugins/ext/artsd/gstartsdsink.c?r1=1.19&r2=1.19.6.1 (Any reason this wasn't commited in HEAD?) BTW, I thought Tim-Philipp Mueller had a nice fix a couple of days ago, at the time the BTS was offline.
Simple, the plugin isn't ported yet. Whoever ports it will take 0.8 code and port it.
*** Bug 312725 has been marked as a duplicate of this bug. ***