After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 308904 - procedural_db_execute core dumps in case a plugin returns 0
procedural_db_execute core dumps in case a plugin returns 0
Status: RESOLVED FIXED
Product: GIMP
Classification: Other
Component: General
2.2.x
Other Linux
: Normal major
: 2.2
Assigned To: GIMP Bugs
GIMP Bugs
Depends on:
Blocks:
 
 
Reported: 2005-06-24 09:52 UTC by Joost Helberg
Modified: 2008-01-15 12:57 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
proposed fix (839 bytes, patch)
2005-06-24 11:10 UTC, Sven Neumann 		accepted-commit_now Details | Review

Description Joost Helberg 2005-06-24 09:52:00 UTC 
Load a very big image and try to save this as a PNG file. The PNG plugin returns
0 (I'll file a bugreport for that later) and the code in procedural_db_execute
(line  315 procedural_db.c) dereferences return_args. This bombs out of course.
The code in procedural_db should be able to cope with a plugin returning 0.
Both 2.2 and 2.3 contain this error.
Comment 1 Sven Neumann 2005-06-24 11:10:24 UTC 
Created attachment 48273 [details] [review]
proposed fix

Does this change fix the problem for you ?
Comment 2 Joost Helberg 2005-06-24 11:18:15 UTC 
This fix solves the problem exactly (I can now see the error message from the
PNG plugin).
thanks!
Comment 3 Sven Neumann 2005-06-24 15:03:28 UTC 
Committed to both branches, closing as FIXED.

2005-06-24  Sven Neumann  <sven@gimp.org>

	* app/pdb/procedural_db.c (procedural_db_execute): if we end up
	without any return values, assume an execution error instead of
	crashing (bug #308904).