After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 308882 - Set Character Encoding bug
Set Character Encoding bug
Status: RESOLVED FIXED
Product: gnome-terminal
Classification: Core
Component: general
2.10.x
Other FreeBSD
: Normal normal
: ---
Assigned To: GNOME Terminal Maintainers
GNOME Terminal Maintainers
list-kmaraas
Depends on:
Blocks:
 
 
Reported: 2005-06-24 03:29 UTC by Jim
Modified: 2005-07-01 23:53 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Changes the cyrillic encoding name (827 bytes, patch)
2005-06-25 19:52 UTC, Michele Baldessari
none Details | Review

Description Jim 2005-06-24 03:29:49 UTC
Distribution/Version: 4.11

The encodings KOI8-R and KOI8-U do not appear on the Set Character Encoding->Add
and Remove menu. This is because they are incorrectly named KOI8R and KOI8U in
gnome-terminal/src/encoding.c and iconv does not recognise these variants.

Solution: rename KOI8R to KOI8-R and KOI8U to KOI8-U in the above file.
Comment 1 Michele Baldessari 2005-06-25 19:49:15 UTC
Hi Jim,

(I'm no huge I18N expert, so correct me if I'm wrong)
here on an Ubuntu breezy system (and on a debian woody system), iconv -l gives
me these:

KOI-8, KOI8-R, KOI8-T, KOI8-U, KOI8, KOI8R, KOI8U

So I'd say both forms are at least understood. Even though the ones without the
'-' are probably just aliases :
michele@kantele:/tmp/glibc-2.3.5/glibc-2.3.5/localedata/charmaps$ ls -1 KOI*
KOI-8
KOI8-R
KOI8-T
KOI8-U

So it might actually make sense to make this change in case since KOI8-* will 
always be present.

I'll attach the trivial patch..

What system/distro was this btw.?


Comment 2 Michele Baldessari 2005-06-25 19:52:30 UTC
Created attachment 48328 [details] [review]
Changes the cyrillic encoding name
Comment 3 Jim 2005-06-26 23:44:11 UTC
Thanks for your reply. I noticed this on FreeBSD with the latest versions of the
relevant software from the ports tree.

You're right that the aliases are out there, but iconv can be very fastidious
about names, for example on my system only UTF-8 and not UTF8 is recognised. I
believe that the hyphenated versions are the canonical names and will therefore
offer greater portability to very strict iconv builds (like mine).
Comment 4 Michele Baldessari 2005-06-27 08:19:59 UTC
Looks like it can be safely applied. Marking as NEW
Comment 5 Kjartan Maraas 2005-07-01 23:53:52 UTC
Commited