After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 308815 - Colors for categories can't be changed
Colors for categories can't be changed
Status: RESOLVED FIXED
Product: evolution
Classification: Applications
Component: general
2.12.x
Other All
: High major
: ---
Assigned To: Milan Crha
Evolution QA team
: 272860 322143 343402 359130 367071 382740 398520 402091 456205 458057 485542 519156 528925 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2005-06-23 19:04 UTC by Hendrik
Modified: 2013-09-13 00:57 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Submitting patch. (2.32 KB, patch)
2006-10-17 06:38 UTC, ushveen kaur
needs-work Details | Review
proposed eds patch (4.39 KB, patch)
2007-06-27 12:57 UTC, Milan Crha
none Details | Review
proposed eds patch (4.48 KB, patch)
2007-06-27 13:34 UTC, Milan Crha
none Details | Review
proposed eds patch (4.77 KB, patch)
2007-06-27 14:41 UTC, Milan Crha
reviewed Details | Review
proposed evo patch (17.96 KB, patch)
2007-06-27 14:47 UTC, Milan Crha
reviewed Details | Review
patch in eds (4.14 KB, patch)
2007-07-23 11:08 UTC, Suman Manjunath
reviewed Details | Review
proposed eds patch ][ (12.65 KB, patch)
2007-10-23 07:47 UTC, Milan Crha
needs-work Details | Review
proposed evo patch ][ (3.42 KB, patch)
2007-10-23 07:54 UTC, Milan Crha
needs-work Details | Review
proposed eds patch ]I[ (11.45 KB, patch)
2007-11-05 16:17 UTC, Milan Crha
committed Details | Review

Description Hendrik 2005-06-23 19:04:05 UTC
Please describe the problem:
when I try to edit or create a "Category" for the tasks and try to
change the color it doesn't work. I can change the color and it shows up
in the dialog. But when I press ok and look into the category again it's
set to black again.

Steps to reproduce:
1. Create a new task
2. Click on the "Category..." Button
3. Select a category and edit it (or create a new one)
4. Change the color (it will change now)
5. Press ok and finish the task



Actual results:
The color won't have changed and if you check it again it's also saved as black

Expected results:
That the color of the category has changed and my task appears in the chosen color.

Does this happen every time?
yes

Other information:
Comment 1 André Klapper 2005-06-24 14:00:16 UTC
confirming this on evolution-2.2.3.0.200506100320-0.snap.ximian.10.1, suse9.2.

targetting to 2.3.
Comment 2 Michael Quinn 2005-10-06 16:48:46 UTC
this still exists in 2.4.1.  Has this been looked at?
Comment 3 André Klapper 2005-10-06 17:01:46 UTC
retargetting
Comment 4 André Klapper 2005-11-22 21:06:41 UTC
*** Bug 322143 has been marked as a duplicate of this bug. ***
Comment 5 André Klapper 2005-12-06 14:28:29 UTC
updating target milestone, upgrading severity - it's totally useless currently.
Comment 6 André Klapper 2006-02-26 15:10:30 UTC
still valid in evo 2.5.91. color gets changed in the dialog, but does not get applied - still the old color if the dialog is opened for a second time.
Comment 7 André Klapper 2006-05-19 18:31:43 UTC
still valid in evo 2.7.1.
retargetting.
Comment 8 André Klapper 2006-05-30 17:09:01 UTC
*** Bug 343402 has been marked as a duplicate of this bug. ***
Comment 9 André Klapper 2006-05-30 17:18:48 UTC
reassigning chakravarthi's bugs to avoid rotting.
Comment 10 Meneer Jansen 2006-05-30 19:00:46 UTC
Andre, thank you for the super-fast reply. Thank you for the work-around. I hope this color problem can be solved very soon. In the monochrome layout of the calendar it is difficult to distinguish between the categories (i.e. "vacation", "work", etc.).
Comment 11 André Klapper 2006-06-17 22:47:20 UTC
harmonizing target milestones, sorry for the noise. (2.6.x -> 2.6)
Comment 12 Srinivasa Ragavan 2006-07-14 07:05:58 UTC
categories's color is no where used and just the icons are used. Im not sure, what was in the mind, when it was implemented. Im not sure, how to use the colors. What color to use, if more than one category is selected. I would prefer to remove colors from categories and go ahead. I remember harish suggested the same on some bug.

harish?
Comment 13 Meneer Jansen 2006-07-14 10:37:44 UTC
I would very much like to kindly urge the developpers to DO try and implement colors for categories. It will make your calandar/agenda MUCH clearer. In other calendar programs I use colors extensively. This is, in my opinion, very important if Evolution is ever to be as widely used as, say, Outlook. Every category and every appointment having the same color makes the layout of Evolution look unclear/vague.
Comment 14 Srinivasa Ragavan 2006-07-14 10:48:07 UTC
Maneer, currently you can assign multiple categoris to events. What color can u use, if each category has a color? I feel, the color makes no sense with the current assignment of categories to events/contacts.
Comment 15 arvind 2006-07-15 06:53:04 UTC
Maneer , this bug had to deal with two issues:
1. making the color change for categories reflected when u open the categories    for editing again               
2. setting the task color the same as that of the categories.

i've fixed the first part...

but wat puzzles me is wat color shd i set to the task when i have more than one category??

ud it not be better if u were to use different task lists instead?

evo has different colors for different task lists..

n as for outlook, i am new to it n i cudnt find any colors for categories there as well.... which i think is most sensible...





Comment 16 Meneer Jansen 2006-07-15 17:36:14 UTC
Y'all are right. I did not realize that one can assign multiple categories to one appointment/task/agenda-item. Indeed, the question is which color to use then... (I NEVER use two categories for one item. Seems a bit odd to me....)

I remember using my Psion and a PIM (personal information manager, probably Lotus Organizer...) in which I gave my vacations the color green and important meetings the color red. In one glance, I could see if I mistakingly scheduled a meeting in my vacation. This is possible in Outlook too. In Outlook that is called a "LABEL". And labels have colors (categories have not...)!

Maybe the color of the first category can be set as the background color of the appointment? Or maybe the "label" option can be introduced in Evolution too? I really like the Month View with different colors for vacations, anniversaries, meetings, etc. Try it and you'll know what I mean. Really. :)
Comment 17 André Klapper 2006-10-05 07:19:09 UTC
*** Bug 359130 has been marked as a duplicate of this bug. ***
Comment 18 Sebastien Bacher 2006-10-07 14:42:02 UTC
Ubuntu bug about that: https://launchpad.net/products/evolution/+bug/52816
Comment 19 ushveen kaur 2006-10-17 06:38:23 UTC
Created attachment 74854 [details] [review]
Submitting patch.
Comment 20 scarolan 2006-10-29 18:47:06 UTC
*** Bug 367071 has been marked as a duplicate of this bug. ***
Comment 21 scarolan 2006-10-29 18:48:05 UTC
Same problem here - I just merged my duplicate bug into this one.  Please fix it, devs!  It's really nice to see different types of appointments in different colors.  I'm using the icons for now, but would be nice to have colors.
Comment 22 Chenthill P 2006-11-06 13:39:47 UTC
The patch does not work properly. It also causes a crash.
Comment 23 Martin Bendle 2006-12-28 15:52:15 UTC
Same problem here: (Evolution 2.8.2.1 on FC6)

If some people like to allow multiple categories for a single item (event/task/contact etc.) (seems silly to me, but I can almost see why) then any of the following are surely reasonable solutions: (approximately increasing preference with number)

1. Force a choice between colouring the item OR allowing multiple categories
2. Let the software choose the colour if multiple categories are selected for a single item
3. Give the user a list of colours in a drop-down menu in an item's dialogue box (made up of the colours of the categories to which it is a member) resulting in the automatic colouring for people who want it, those that don't won't have gone to the trouble of setting category colours in the first place.

It would also be nice to have the option different category sets (probably through enabling or disabling) for the address book, calendar, memos etc. (how many contacts do you have in your "To Do" or "Ideas" category).  This should also improve compatibility with the Palm OS calendar software.

I know these are technically feature requests, however it appears that it is the lack of one of these that is probably (indirectly) the cause of the bug.
Comment 24 André Klapper 2007-02-09 00:35:13 UTC
*** Bug 402091 has been marked as a duplicate of this bug. ***
Comment 25 André Klapper 2007-04-13 20:02:21 UTC
*** Bug 382740 has been marked as a duplicate of this bug. ***
Comment 26 Milan Crha 2007-06-27 12:57:16 UTC
Created attachment 90749 [details] [review]
proposed eds patch

for evolution-data-server;

it's only to allow save/load colors with categories, those colors are need to be used (somehow) in evolution itself, as next step.

This patch also contains a fix for runtime warning:
(evolution:789): e-data-server-CRITICAL **: e_categories_get_icon_file_for: assertion `cat_info != NULL' failed
which is very very annoying for me and is not necessary. :)
Comment 27 Milan Crha 2007-06-27 13:34:00 UTC
Created attachment 90750 [details] [review]
proposed eds patch

for evolution-data-server;

almost same as that previous one, but here if one choose pure black (rgb(0,0,0)) then the color is unset (clear) from the category. (I meant "don't save pure black color")
Comment 28 Milan Crha 2007-06-27 14:41:19 UTC
Created attachment 90754 [details] [review]
proposed eds patch

for evolution-data-server;

one more annoying runtime warning removal, now in e_categories_get_color_for
Comment 29 Milan Crha 2007-06-27 14:47:08 UTC
Created attachment 90755 [details] [review]
proposed evo patch

for evolution;

it uses rather color based on category for the event for day/month view, but in list view is still used calendar color. It will use calendar color in day/month view too when there are selected more categories with colors in the event (notice, it's not same as more categories, because some categories don't need to have selected color).
Comment 30 Toni 2007-06-28 23:15:44 UTC
Hi Milan,

first of all thank you for your work on this bug.
how can i add this patch into my evolution?
do i have to compile evolution with the changed files of your patch?
i have ubuntu, can you explain how i can use your patch on the easiest way?

Thank you,

Toni
Comment 31 André Klapper 2007-06-28 23:38:06 UTC
hi toni, you would have to compile evolution from source with the patch included. warning: compiling from source is not trivial. :-)
Comment 32 Milan Crha 2007-06-29 06:41:51 UTC
Hi Toni,
Andre has right, it is not trivial, also not much complicated, but I will rather try to persuade evolution developers to review this, maybe fix some issue they find there, and then it will be included in new release.
But it will take some time, we will see.
Comment 33 Gilles Dartiguelongue 2007-07-03 12:03:06 UTC
Would somebody that has the vision of how it should look like would do us the favor of attaching a mockup (even gross). I don't quite see how to mix the color of the task list with the color of the categories.
Comment 34 Thomas Boksberger 2007-07-03 16:27:55 UTC
Hi Gilles Dartiguelongue
One way is to do it like sunbird with the colored border. I don't prefer it, but it works...
The other way could be to make ist configurable. So the user can decide from where the color should be taken (from category or tasklist). I think this way is better. 

@developers
I work with Evolution 2.10.1 on a Ubuntu feisty and the problem still exists. Can somebody change the target milestone. 
thx
Comment 35 André Klapper 2007-07-12 14:19:22 UTC
*** Bug 456205 has been marked as a duplicate of this bug. ***
Comment 36 André Klapper 2007-07-19 00:45:47 UTC
*** Bug 458057 has been marked as a duplicate of this bug. ***
Comment 37 Suman Manjunath 2007-07-23 11:08:19 UTC
Created attachment 92195 [details] [review]
patch in eds

the patch fixes only the 'color-sticking' for categories..
Comment 38 Srinivasa Ragavan 2007-07-26 08:02:07 UTC
How to show colors of categories? What if an event has 10 categories and has in turn 10 colors to be shown? Anything idea to show this is a better way?

Icons do a good job here. I wondered why was this colors added and not used anywhere. I propose we should remove this. Any thoughts?
Comment 39 Carsten Nikiel 2007-08-23 09:19:31 UTC
How about sorting the categories?
Pick the first one that is marked as the one giving the color.

I personally believe that having colors is a lot easier to figure out what MAIN category an appointment belongs to.

Personal - Green
Business - Red

Those would be my topmost categories.
Down the road I would add less important ones.
Comment 40 Srinivasa Ragavan 2007-08-23 13:38:11 UTC
May be you are saying category ranking. That is a different requirement altogether. Even then, I dont think it can support/vote for colors for categories. I strongly feel that icons are doing a good job and color aren't there anyway today in the visual cue and lets remove it from the editor also. 
Comment 41 Carsten Nikiel 2007-08-23 16:33:03 UTC
Hmm, OK I can understand why you are against colors for categories.
BUT will you add LABELS instead that have colors?
Like Outlook and all other Calendar software does?

I feel not pretty happy with the small icons and if I set a couple of them I can not easily see which ones are important, or if I am busy or if they are private etc.

Color scheming is a lot easier to grasp.

Just for the fun try to add 10 categories to a busy weeks schedule and then tell me with one look which days have 1 specific set.

But if you have set a color scheme for exactly this one it will be right there in your face.

Like the Personal - Green and Business - Red example I gave.
Comment 42 Srinivasa Ragavan 2007-08-23 17:03:00 UTC
Carstem, labels/tags are nice concepts. We need to make a proposal on how we gonna implement them and showcase it. It lot depends on the proposal and the functional specification. If the spec can make a unambiguous proposal with colors, I'm not against it really.
Comment 43 Carsten Nikiel 2007-08-28 05:37:35 UTC
I guess the easiest (in my humble opinion) would be to stick to the categories as they are (with the corresponding colors).

For the labels/tags create a second pulldown list in which you can select ONE single category.

From that category you take the color and show it in the calendar.

That was there is no need to change the code for the categories.

You would have one additional field to save for each appointment and one pulldown chooser for the label/tag.

Comment 44 Milan Crha 2007-09-04 13:39:46 UTC
*** Bug 398520 has been marked as a duplicate of this bug. ***
Comment 45 André Klapper 2007-10-16 00:18:02 UTC
*** Bug 485542 has been marked as a duplicate of this bug. ***
Comment 46 Milan Crha 2007-10-23 07:47:54 UTC
Created attachment 97703 [details] [review]
proposed eds patch ][

for evolution-data-server;

after a discussion with srag about this bug on IRC, here's a patch to drop colors from categories. All related functions are marked deprecated and one deprecated function 'e_categories_add_with_color' has been added to be able to use function like before (when not disabled deprecated), and to be able to use 'e_categories_add' every time, without any knowledge of EDS_DISABLE_DEPRECATED.
There is also fixed one runtime critical warning which was shown when editing category without icon.
Comment 47 Milan Crha 2007-10-23 07:54:05 UTC
Created attachment 97704 [details] [review]
proposed evo patch ][

for evolution;

Prototype of 'e_categories_add' function has been changed, so make this change in our code too.
Comment 48 Srinivasa Ragavan 2007-11-05 06:40:19 UTC
Milan, rejected. You have broken the API e_category_add. Not acceptable.
Deprecate that and add another one to do with out color.
Comment 49 Milan Crha 2007-11-05 16:17:09 UTC
Created attachment 98570 [details] [review]
proposed eds patch ]I[

for evolution-data-server;

evo patch is no longer needed, because after a discussion on IRC we decided to deprecate only a parameter 'color' of 'e_categories_add', renaming to 'unused', because any other new function will have a suffix, which will/can invoke thought that there is other method to add a category, but that one is deprecated.
Comment 50 arvind 2007-11-24 06:19:33 UTC
Hello , 

I am STRONGLY in favour for the colour coding and these are my proposals for dealing with this issue:

1) Srini had mentioned about the feasiblity for a colour ranking. IT CAN BE DONE!!
Assign priority in the form of integers to the category colours and break ties by checking the highest bit set for each of the categories. If at a stage, two categories have the highest bit set , then check for the next bit and so on..And since no two categories have the same priority , this WILL yield a solution. And all these bitwise operations should be pretty easy to code and will take up little memory.
There are 22 categories( Phew, isn't that a lot?? ) and the priorities would have to be decided over IRC by both clients and devs.

2) Remove the category colours and bring in the concept of label colouring like Outlook. This too should not be difficult. Just remove the color field from the structure of the category and add an additional data structure label and the user may choose only one label which means , only one colour, and voila, we have a solution :)


Eagerly awaiting  all your comments on this.  
(Its been a long time, Srini and Andre. Looking forward to hearing from you guys)

Cheers :)
Comment 51 Srinivasa Ragavan 2007-11-26 03:17:24 UTC
Arvind,

Again, as I said, this would mostly match with priority rather than categories. My basic point is that if two categories have two colors then what to do? If we want to go by colors of item, the theme for calendar/tasks/memo colors would go off. I still feel that outlook way is a bit different. They have color bubbles attached to a event, the way we attach icons in it. The event would take the color of the calendar which makes it much easier and icons rather than colors is a better way to understand categories IMO.

I'm going with this for now, for 2.22.


Milan, 

I think you can commit this to head. One correction 

+/* 'unused' parameter was 'icon', but it is deprecated now (see bug #308815) */

was 'color' :)
Comment 52 Milan Crha 2007-11-26 09:59:29 UTC
Committed to trunk. Committed revision 8243.

How this happened? Hmmmm :)
Comment 53 Carsten Nikiel 2007-11-26 13:41:12 UTC
Hi Srinivasa,
well in my work environment we have no permissions to create a couple of calendars.
We are stuck with ONE and only ONE exchange calendar.
This makes your approach of color coding different calendars pretty difficult.
And seeing the difference between a couple of small icons which have essentially the same color is not making it easier.

I would have liked to see something like color coded labels, but it seems like we are not getting them. :-(
Comment 54 Jens Getreu 2007-11-26 16:14:24 UTC
I share in every way the point of view of comment #13:

"I would very much like to kindly urge the developpers to DO try and implement
colors for categories. It will make your calandar/agenda MUCH clearer. In other
calendar programs I use colors extensively. This is, in my opinion, very
important if Evolution is ever to be as widely used as, say, Outlook. Every
category and every appointment having the same color makes the layout of
Evolution look unclear/vague."

Still valid in evolution 2.12.1 ubuntu 07.10.


Comment 55 André Klapper 2008-02-28 11:50:27 UTC
*** Bug 519156 has been marked as a duplicate of this bug. ***
Comment 56 André Klapper 2008-04-21 15:15:05 UTC
*** Bug 528925 has been marked as a duplicate of this bug. ***
Comment 57 Yogiz 2008-04-29 19:43:15 UTC
I also have to join with all the people here that consider category colors essential for using the application. As far as I know, the option exists in pretty much every other rfc2445 compliant PIM. Why change it? The little icons are completely incapable of distinguishing all the categories in my full week calendar. Colors are hugely better at this. Colored categories let me get a overview of my week in a second. Icons make me use at least 10 to go over every single appointment. Also don't split colors into another thing (labels whatever). It should be possible to make them go hand in hand with rfc's categories. I sync my calendar with my phone where I use categories as well and do not intend to start manually coloring/labeling every appointment. Just make the categories for an event sortable and show the color of the first category. This really isn't that hard.

I will downgrade to last working evolution for now and I really beg you to fix this bug. There really aren't any good open-source pims for me to migrate at the moment.

Yogiz
Comment 58 Srinivasa Ragavan 2008-04-30 05:32:58 UTC
Yogiz, AFAIK, there was no impl for colors in Evo. It was just the UI lying there. So, even if you downgrade, there is nothing much gonna be there, except the UI. Or I'm not clearly getting the point.

Note that calendars already have colors. And that is used a lot than this. How is thing gonna be merged with multiple catergory colors.  If I have a convincing answer/proposal for this, Im really not against it. At the end, I dont want to disappoint any user, at the same time, dont want a confusing UI. Thanks.
Comment 59 Yogiz 2008-04-30 06:25:21 UTC
You are indeed correct and I found out, that downgrade will not be an option. The problem with using different calendars as categories (colors) is that they're quite hard to sync with the cell phone as the latter can only use one calendar. I would suggest you add the option for color categories in the preferences, configurability is something in my opinion, that you can not have too much of on a large software project such as Evolution.

As for multiple categories and colors, I already proposed, make categories sortable and only show the color of the topmost one. I think that would work out quite well, don't you think?

I would not like to go off-topic, but it seems to me, that lately the developers assume too much, to what the user wants. I'd really suggest to make the software as possibly configurable as it can be. I for one would like to be able to compile evolution without the mail part and just use it as a pim. Also the 3D view of appointments should be possible to turn off. I haven't found an option for that eighter. <\rant>

The off-topic part can be ignored but I'd be interested if the color categories could still be re-implemented.
Comment 60 Srinivasa Ragavan 2008-04-30 06:40:00 UTC
Yogiz, for the 3D view, you can disable/adjust a few things like gradient (Make it look like 3d), transparency etc. But you cant go back to old view. 

Do you mean to say that have a conf to say, Use colors from categories/calendars while drawing appt? Sounds fine.

But how would you solve the multiple categories colors then. we can have color bubbles in the appt of all the categories, but dont render the appt in one of the colors from category. It is actually loss of information and it can mislead. You need to have category ranking to tell which one to take out of the existing category colors.
Comment 61 Yogiz 2008-04-30 07:55:07 UTC
Yes, I mean to have such a configuration option.

I'm not sure I got the rest correctly. Let's say there are three categories and colors defined for them: Personal (blue), work (red) and misc (white). Now when I create an appointment and select only one of these categories app is rendered in this color. If I select more then one, I can sort the categories for the app. When I select all three categories for an app then I could be able to drag and drop these categories in a list. The app will be rendered in the color of the topmost category.

Categories:
work
misc

app is rendered in red

Categories
misc
personal
work

app is rendered in white.

I'm also for the icons as they exist right now. That can give more detailed overview of the categories on a closer inspection but they're not as good for general sorting as colors.

Hope I made myself clear : ).
Comment 62 Carsten Nikiel 2008-04-30 09:40:04 UTC
OK, since this issue is being discussed again I would like to put my 0.2 cent into it.

How about borders?
Color the border with the calendar color and the background with the category color.

If a user wishes so he could swap the two. Make it configurable.

This way you have both in one go.
The color coding for the calendar and the color coding for the category.

I also vote for the category sorting.
Comment 63 Yogiz 2008-04-30 11:40:04 UTC
Nikiel's idea would work out just fine for me. If you need a quick way to distinguish the different calendars then that would be a good way to do so. Always make things more configurable rather then less. That should be the beauty of open-source.
Comment 64 Milan Crha 2009-07-23 13:15:22 UTC
*** Bug 272860 has been marked as a duplicate of this bug. ***
Comment 65 Daniel Münch 2009-10-13 14:20:18 UTC
Carsten Nikiel's would also be a good solution to me!
Another way would be to decide in the preferences if you would like to use colors for categories or calendars.
The categorie-icons are nice but not as good to see.