GNOME Bugzilla – Bug 308787
Command line full-screen option.
Last modified: 2008-10-28 07:18:42 UTC
Distribution: Gentoo Base System version 1.6.12 Package: EOG Severity: enhancement Version: GNOME2.10.0 2.8.2 Gnome-Distributor: Gentoo Synopsis: Command line full-screen option. Bugzilla-Product: EOG Bugzilla-Component: general Bugzilla-Version: 2.8.2 Description: It would be nice if there was an option to start the image viewer in full screen mode, ie: eog --fullscreen sexy_lady.jpg Aditionally it would be nice to stop the new side bar (that shows image information) from appearing each time you start a new instance of eog. ------- Bug moved to this database by unknown@bugzilla.gnome.org 2005-06-23 15:10 UTC ------- The original reporter of this bug does not have an account here. Reassigning to the person who moved it here, unknown@bugzilla.gnome.org. Previous reporter was komoto@gmail.com.
The image information sidebar can be hidden in newer versions of EOG. The --fullscreen command line option seems a valid feature request. Confirming.
Also, a --slideshow option would be nice. (Just to keep track of this "more command line option" request)
*** Bug 327857 has been marked as a duplicate of this bug. ***
Moving to 2.17.x
Add myself to CC list
Bug #376513 (TRACKER) was created by me for command-line bugs.
Created attachment 77518 [details] [review] command line options: fullscreen, slide-show and disable-collection. Also fix bug #336712 and bug #376560.
Ready to commit???
Hey Bruno, I'll review and commit it tonight (finnish time). :-)
Hey Bruno, Some pending issues: 1. On file_open_dialog_response_cb, you should pass no startup flags instead of window->priv->flags. It's like a different "startup" when you're opening images from file chooser. 2. The fullscreen and slideshow option work ok but the window should first appear already in fullscreen mode and not in normal mode and then in fullscreen. 3. Disable image collection is not working correctly. You need to take the startup flags into account when running update_action_groups_state. You just need to force the image collection show/hide gconf key to FALSE if the --disable-image-collection option was used. 4. Coding style: take care of making all code lines not exceed 80 columns and indenting should follow the same stardard. Thanks for your help! Fix this problems and I'll commit it as soon as possible. :-)
Fixed in eog-ng branch, thanks! I had to fix this patch myself because I need it ready to implement some other things. As there's no plan at all to fix this in HEAD, I'm closing this bug report. 2006-12-26 Lucas Rocha <lucasr@gnome.org> New command-line options for EOG: -s to start in slideshow mode, -f to start in fullscreen mode, and -c to disable collection pane on startup (Fixes bugs #308787, #336712, #376560, #376513). Based on patch from Bruno Boaventura <brunoboaventura@gmail.com>. * shell/eog-window.[ch]: add startup flags to EogWindow. Consider those flags when constructing the UI. * shell/eog-application.[ch]: Update API to receive the EogWindow startup flags. * shell/main.c: initialize startup flags based on passed command-line options.
*** Bug 558166 has been marked as a duplicate of this bug. ***