GNOME Bugzilla – Bug 308779
Clear Recent Documents does not work immediately
Last modified: 2005-08-22 20:22:30 UTC
Distribution: Debian testing/unstable Package: gnome-menus Severity: normal Version: GNOME2.10.1 2.10.x Gnome-Distributor: Debian Synopsis: Clear Recent Documents does not work immediately Bugzilla-Product: gnome-menus Bugzilla-Component: general Bugzilla-Version: 2.10.x Description: Description of Problem: In GNOME 2.10 on Debian Unstable, the Places -> Recent Documents -> Clear Recent Documents option does not seem to work with immediate effect. The list of recent documents is not cleared and remains visible at subsequent instances when the Places -> Recent Documents menu is clicked. Steps to reproduce the problem: 1. Use GNOME to view/edit a few documents 2. Attempt to clear the recent documents list (as above) 3. Click on Places->Recent Documents again in order to see list still present. Actual Results: List is not cleared. Expected Results: List should be cleared immediately. How often does this happen? Additional Information: ------- Bug moved to this database by unknown@bugzilla.gnome.org 2005-06-23 13:52 UTC ------- The original reporter of this bug does not have an account here. Reassigning to the person who moved it here, unknown@bugzilla.gnome.org. Previous reporter was paul.syred@exeter.oxford.ac.uk.
Looks like egg_recent_model_clear() relies on getting a FAM notification that the file has been truncated. Why not explicitly queue a re-read? (Obviously, if we're not getting a FAM notification, there's a bug in gamin or FAM)
I'm not able to reproduce this problem with the newly built panel. For me the recent documents list is getting cleared instanteneously.
*** Bug 311341 has been marked as a duplicate of this bug. ***
Problem is that egg_recent_model_clear() doesn't update immediately if FAM isn't available - other functions like egg_recent_model_add() do do this. Attaching a patch
Created attachment 49700 [details] [review] recently-used-fix-clearing-in-absence-of-gamin.patch
2005-08-22 Emmanuele Bassi <ebassi@cvs.gnome.org> * libegg/recent-files/egg-recent-model.c: (egg_recent_model_init), (egg_recent_model_poll_timeout), (egg_recent_model_finalize), (egg_recent_model_monitor): If FAM support is unavailable, manually poll the .recently-used file (patch by Dinoop Thomas, fixes bug #140153). * libegg/recent-files/egg-recent-model.c: fixes compilation on Darwin where lockf() isn't exported (patch by Jerry Talkington, fixes bug #124238). * libegg/recent-files/egg-recent-model.c: (egg_recent_model_clear): if FAM is not available, force update of the list when removing an item (patch by Mark McLoughlin, fixes bug #308779). * libegg/recent-files/egg-recent.h: added header guards; this is a convenience header, so you should not use it anyway (fixes bug #108101).