After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 308748 - distorts-->shift splits rows to 64px parts
distorts-->shift splits rows to 64px parts
Status: RESOLVED FIXED
Product: GIMP
Classification: Other
Component: Plugins
2.2.x
Other All
: Normal minor
: 2.2
Assigned To: GIMP Bugs
GIMP Bugs
Depends on:
Blocks:
 
 
Reported: 2005-06-23 08:14 UTC by Jakub Friedl
Modified: 2008-01-15 12:57 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
proposed fix (5.37 KB, patch)
2005-06-23 10:44 UTC, Sven Neumann 		none Details | Review

Description Jakub Friedl 2005-06-23 08:14:01 UTC 
Please describe the problem:
Because of our current docs, common sense and the comment in the shift.c file
itself i believe, that this filter is supposed to shift whole pixel rows or
colums  of a layer/selection. However this is not the case: rows (colums) are
split to 64 pixel long parts before shifting - a different random shift is used
for each part.
It produces nasty artifacts. If you do not consider this to be a bug, consider
it an enhancement request. 

Steps to reproduce:
1. fill an empty image with the Stripes fine pattern
2. shift vertically
3. see the artifacts


Actual results:
see above

Expected results:
see above

Does this happen every time?
yes

Other information:
Comment 1 Sven Neumann 2005-06-23 10:07:11 UTC 
The current code operates on tiles (which is good) and instead of precalculating
an array of random shift offsets, it throws the dice for each row/column of a
tile. Shouldn't be hard to fix.
Comment 2 Sven Neumann 2005-06-23 10:44:04 UTC 
Created attachment 48205 [details] [review]
proposed fix

Does this change fix the problem?
Comment 3 Jakub Friedl 2005-06-23 11:46:04 UTC 
yes, it looks good, thanks
Comment 4 Sven Neumann 2005-06-23 17:00:35 UTC 
Applied to both branches then. Closing as FIXED.

2005-06-23  Sven Neumann  <sven@gimp.org>

	* plug-ins/common/shift.c: shift whole rows/columns, instead of
	tiles. Fixes bug #308748.