After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 308662 - Script-FU Section crashes on 'OldPhoto'-abbortion
Script-FU Section crashes on 'OldPhoto'-abbortion
Status: RESOLVED FIXED
Product: GIMP
Classification: Other
Component: Script-Fu
2.2.x
Other All
: Normal critical
: 2.2
Assigned To: GIMP Bugs
GIMP Bugs
Depends on:
Blocks:
 
 
Reported: 2005-06-22 16:31 UTC by Stefan Borschtel
Modified: 2008-01-15 12:57 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Stefan Borschtel 2005-06-22 16:31:32 UTC
Start script-fu->deco->old photo and while processing close the script-window.
The whole script-fu-section crashes -> no script-fu-menu available anymore
Comment 1 Kevin Cozens 2005-06-22 20:44:23 UTC
Closing the main dialog associated with a running script is probably not the
nicest thing to do. Once the dialog has been closed, another dialog pops up with
comments about the plug-in may have died and the number of times the message has
been repeated. The warning message seems to be appearing for each attempt to
update the progress bar (which is a lot of times). The script will run to
completion and the updated image will appear but script-fu dies with a
segmentation fault.

I wouldn't be surprised to learn that this problem can be reproduced by closing
most (all?) of the other scripts which use the progress bar. It shouldn't be too
hard to track down what is causing the seg fault.
Comment 2 Sven Neumann 2005-06-22 21:15:30 UTC
Closing the window is equivalent to pressing the Cancel button in the dialog. I
might be wrong but I think the effect of pressing Cancel is to kill Script-Fu.
So this would be a duplicate of bug #109605.
Comment 3 Sven Neumann 2005-06-23 00:02:39 UTC
Eeek, actually it appears to be gimp that is crashing here, not Script-Fu:

gimp-2.3: fatal error: Segmentation fault
gimp-2.3 (pid:3151): [E]xit, [H]alt, show [S]tack trace or [P]roceed: s
  • #0 g_on_error_stack_trace
    from /usr/lib/libglib-2.0.so.0
  • #1 g_on_error_query
    from /usr/lib/libglib-2.0.so.0
  • #2 gimp_eek
  • #3 gimp_fatal_error
  • #4 gimp_sigfatal_handler
    at main.c line 551
  • #5 <signal handler called>
  • #6 procedural_db_return_args
  • #7 plug_in_get_return_vals
  • #8 plug_in_run
  • #9 procedural_db_execute
  • #10 procedural_db_run_proc
  • #11 gimp_pdb_progress_run_callback
  • #12 gimp_pdb_progress_progress_set_value
  • #13 progress_update_invoker
  • #14 procedural_db_execute
  • #15 plug_in_handle_message
  • #16 plug_in_recv_message
  • #17 g_vasprintf
    from /usr/lib/libglib-2.0.so.0
  • #18 g_main_depth
    from /usr/lib/libglib-2.0.so.0
  • #19 g_main_context_dispatch
    from /usr/lib/libglib-2.0.so.0
  • #20 g_main_context_dispatch
    from /usr/lib/libglib-2.0.so.0
  • #21 g_main_loop_run
    from /usr/lib/libglib-2.0.so.0
  • #22 plug_in_run
  • #23 procedural_db_execute
  • #24 plug_in_handle_message
  • #25 plug_in_recv_message
  • #26 g_vasprintf
    from /usr/lib/libglib-2.0.so.0
  • #27 g_main_depth
    from /usr/lib/libglib-2.0.so.0
  • #28 g_main_context_dispatch
    from /usr/lib/libglib-2.0.so.0
  • #29 g_main_context_dispatch
    from /usr/lib/libglib-2.0.so.0
  • #30 g_main_loop_run
    from /usr/lib/libglib-2.0.so.0
  • #31 plug_in_main_loop
    at plug-in.c line 952
  • #32 plug_in_run

Comment 4 Sven Neumann 2005-06-24 17:28:56 UTC
It's simple to prohibit further use of the progress pdb callback after it has
failed once. I added two lines of code to app/pdb/gimppdbprogress.c and it stops
the warning to be repeated over and over again. But since the script continues
to run w/o any progress indication then, that is probably not the right fix or
only part of it.
Comment 5 Michael Natterer 2005-09-11 01:19:13 UTC
The cancel button is insensitive while the script is running, so the
right thing to do would be to ignore closing the window as well.
Comment 6 Michael Natterer 2005-09-11 01:33:40 UTC
Fixed in both branches:

2005-09-11  Michael Natterer  <mitch@gimp.org>

	* plug-ins/script-fu/script-fu-interface.c (script_fu_response):
	bail out if the action_area is insensitive. Ignores attempts to
	close the window while the script is running. Fixes bug #308662.