After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 308644 - [matroska] Incorrect pixel-aspect-ratio in matroska demuxer
[matroska] Incorrect pixel-aspect-ratio in matroska demuxer
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins
git master
Other Linux
: Normal normal
: 0.8.10
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2005-06-22 13:04 UTC by Michal Benes
Modified: 2005-06-22 15:09 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Patch to initialize display_width and display_height correctly (716 bytes, patch)
2005-06-22 13:09 UTC, Michal Benes
committed Details | Review

Description Michal Benes 2005-06-22 13:04:19 UTC
videocontext->display_width and videocontext->display_height are not initialized
when they are not found in caps and hence the pixel-aspect-ratio is computed as
more or less random fraction (even negative)
Comment 1 Michal Benes 2005-06-22 13:09:39 UTC
Created attachment 48154 [details] [review]
Patch to initialize display_width and display_height correctly

The problem is that videocontext->display_width and ideocontext->display_height
are not initialized, however, later there is a test 
if (videocontext->display_width > 0 && videocontext->display_height > 0)
and if this is true, pixel-aspect-radio is computed and set to caps.
This pixel-aspect-ratio can be even negative which confuses xvimagesink.
Comment 2 Tim-Philipp Müller 2005-06-22 15:09:04 UTC
Thanks, applied to the 0.8 branch (with minor modifications, I zeroed the
pixel_width, pixel_height and fourcc fields as well):

2005-06-22  Michael Benes  <michael dot benes at xeris dot cz>

        Reviewed by: Tim-Philipp Muller  <tim at centricular dot net>

        * gst/matroska/matroska-demux.c: (gst_matroska_demux_add_stream):
          Initialize the video context properly, so we don't get random
          aspect ratios when no aspect ratio is set (#308644).


 Cheers
  -Tim