GNOME Bugzilla – Bug 308335
[PATCH] ffmpeg postprocessing plugins
Last modified: 2005-06-20 16:03:22 UTC
I finally wrapped the libpostproc which is in ffmpeg. No parameters are available yet, apart from the quality (which is by default at best quality).
Created attachment 48019 [details] [review] patch for postproc requirements
Created attachment 48020 [details] the ext/postproc directory tarball
Created attachment 48021 [details] [review] previous tarball as a patch
So it doesn't actually do anything yet...? :) Approach looks good otherwise, now make it work and I'll be happy (and you can apply).
Created attachment 48034 [details] [review] New version with proper in_place processing
+ /* + TODO : We need to find out what CPU flags we have in order to set + MMX/MMX2/3DNOW optimizations + */ That doesn't look good, since it is implemented. Please remove. +/* inplane[0] = GST_BUFFER_DATA(in); */ +/* inplane[1] = inplane[0] + postproc->ysize; */ +/* inplane[2] = inplane[1] + postproc->usize; */ Since you don't use the inplane, can you remove it? Apart from those two minor issues, it looks good. Please apply. Please run it through gst-indent before applying, I'm trying to keep style in the .c files consistent (and am faling hopelessly :) ).
ok, removing those comments, indenting it and commiting it
commited, you may close if needed
Edward: you fixed it, so why don't you close it? That way if you mark this and 10 other plugins for Gstreamer in the coming week you'll appear at: http://bugzilla.gnome.org/reports/weekly-bug-summary.html
So I'm gonna be an ass, but I'll reopen and mark as resolved/fixed, since I use bugs with that status and a target milestone set for the release notes. ;).