GNOME Bugzilla – Bug 308332
File chooser resets file name entry when using type ahead
Last modified: 2006-02-09 15:52:50 UTC
Version details: 2.6.8 Distribution/Version: paldo testing Since gtk+ 2.6.8 the file chooser resets the file name entry when using type ahead (to choose folder) in save mode. It also happens when deselecting the currently selected folder by ctrl+clicking but the latter probably doesn't happen often in normal use cases. The patch http://cvs.gnome.org/viewcvs/gtk%2B/gtk/gtkfilechooserdefault.c?r1=1.265&r2=1.266 (in 2.6.8 and HEAD) seems to have introduced this behaviour.
Looks like its not easy to fix. The treeview currently does not have a way to find out that a selection change was during typeahead.
Created attachment 48738 [details] [review] Fix attempt I don't know the file chooser code at all but perhaps the attached simple patch can solve the problem. Very possible that I've overlooked something but it may be worth an attempt...
*** Bug 309638 has been marked as a duplicate of this bug. ***
As noted in the duplicate, this interferes with the "Create Folder" button --- hitting it clears the filename entry, which is definitely wrong.
*** Bug 312053 has been marked as a duplicate of this bug. ***
I'm a little fascinated that this wasn't fixed before 2.8.0 was released. This is a regression on previous file-chooser behaviour and it's quite annoying, making saving of files very complicated if you want to retain the file name that was supplied (which most people would I would think).
*** Bug 314219 has been marked as a duplicate of this bug. ***
*** Bug 315849 has been marked as a duplicate of this bug. ***
How is the fix attempt coming on?
I just committed the patch from comment #2 to HEAD and gtk-2-8. Sorry for taking so long in reviewing it. Thanks for the patch, Jürg! 2005-09-27 Federico Mena Quintero <federico@ximian.com> Merged from HEAD: * gtk/gtkfilechooserdefault.c (update_chooser_entry): If the selection is empty, clear the file name entry only if we are in CREATE_FOLDER mode. In SAVE mode, nothing will be selected when the user starts typeahead in the treeview, and we don't want to clear the file name entry in that case --- the user could be typing-ahead to look for a folder name. Fixes bug #308332, patch by Jürg Billeter.
Thanks a lot!
Is there a chance the patch will be commit to 2.6.x too ?
Why ? There will not be any further 2.6.x releases
Here in my coporate environment, gnome 2.10 is quite stable now (latest release with latest few cvs 2.10 patches). I know "by experiment" that migrating to gtk 2.8 (at least now) will bring some other problems.
Yes, but we lack the manpower to maintain three branches in parallel. So if you need that patch in 2.6, you need to patch your installation, or ask your distribution to patch their package.
I deeply understand and agrre with you,but that's more political than technical. I'm a big fan of gnome/gtk since the begining and your everyday's hard work proves I'm right. But since I migrated all my users -from Windows,Sun CDE,even KDE (but no flame there), to gnome, I have to justify my choice. And it's easier to say "Look, you have this bug, there's already a patch in cvs" than "OK, huum, let's migrate to 2.12..." In a coorporate environment , that's not so easy ... I can't, technically and politically, migrate everyone every 6 months. I check for every patches applied by RedHat (Fedora) , but this is far from being as useful as checking bugzilla, or cvs.
*** Bug 316303 has been marked as a duplicate of this bug. ***
*** Bug 316869 has been marked as a duplicate of this bug. ***
*** Bug 323193 has been marked as a duplicate of this bug. ***
*** Bug 324271 has been marked as a duplicate of this bug. ***
*** Bug 330519 has been marked as a duplicate of this bug. ***