After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 308276 - Missing name in V-folder error message dialog
Missing name in V-folder error message dialog
Status: RESOLVED FIXED
Product: evolution
Classification: Applications
Component: Mailer
2.8.x (obsolete)
Other Linux
: Normal trivial
: ---
Assigned To: evolution-mail-maintainers
Evolution QA team
Depends on:
Blocks:
 
 
Reported: 2005-06-19 11:01 UTC by Pavel Šefránek
Modified: 2013-09-13 00:52 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
There is a missing name of V-folder between double apostrophes ("") (18.07 KB, image/png)
2005-06-19 11:05 UTC, Pavel Šefránek
  Details
Fixed (1.42 KB, patch)
2006-08-21 07:34 UTC, ushveen kaur
needs-work Details | Review
thanx andre.resubmitting the patch. (1.27 KB, patch)
2006-08-22 03:48 UTC, ushveen kaur
committed Details | Review

Description Pavel Šefránek 2005-06-19 11:01:17 UTC
Missing folder name in V-folder error message dialog. See attached picture for
additional information.
Comment 1 Pavel Šefránek 2005-06-19 11:05:29 UTC
Created attachment 47983 [details]
There is a missing name of V-folder between double apostrophes ("")
Comment 2 André Klapper 2006-01-21 01:01:16 UTC
still in 2.5.5. retargetting.
Comment 3 Pavel Šefránek 2006-03-29 19:02:19 UTC
Still in 2.6.0. Any news?
Comment 4 André Klapper 2006-07-14 20:12:01 UTC
retargetting.
Comment 5 Pavel Šefránek 2006-07-14 21:08:40 UTC
Maybe you can fix that bug by editing line #290 in evolution/mail/mail.error.xml from "<_secondary xml:space="preserve">A folder named &quot;{1}&quot; already exists. Please use a different name.</_secondary>" to "<_secondary xml:space="preserve">A folder named &quot;{0}&quot; already exists. Please use a different name.</_secondary>".

Language files should be updated too (maybe).
Comment 6 Pavel Šefránek 2006-07-14 21:17:04 UTC
Oops, I gave a bad bug status, please change it to "in progress" or something like this, but not closed.
Comment 7 André Klapper 2006-07-14 21:18:40 UTC
pavel: hmm, yeah. but why WONTFIX? :-)
Comment 8 André Klapper 2006-07-14 21:20:38 UTC
hehe, okay :-)
Comment 9 ushveen kaur 2006-08-21 07:34:13 UTC
Created attachment 71277 [details] [review]
Fixed
Comment 10 André Klapper 2006-08-21 14:56:29 UTC
ushveen: the patch is not clean, it also includes a second changelog entry. :-)
Comment 11 ushveen kaur 2006-08-22 03:48:37 UTC
Created attachment 71343 [details] [review]
thanx andre.resubmitting the patch.
Comment 12 André Klapper 2006-08-22 09:23:59 UTC
while testing this bug and the patch (the patch works fine, by the way!), i ran into the following issue:

go to edit > search folders. add a search folder with a name that already exists (here: "bla"). error message:

	Name "bla" already used
	Please choose another name.

right-click on "Search folders" in the folder list pane, choose "create folder" (or "new folder" or whatever it is). add a folder name that already exists and once again click on the "search folders" folder list entry. after that you can select the sources and click OK. error message:

	Cannot add Search Folder "bla".
	A folder named "" already exists. Please use a different name.

best way here, in my humble opinion, would be to enhance the patch by harmonizing the strings and to closely look at the code. i prefer the latter one, as it is easier for the user to understand what has gone wrong here.

ushveen, can you update the patch so also the error messages get harmonized? thanks a lot.
targetting to 2.9 as this will break the string freeze.

guess i will investigate a bit into "similar error messages" and have moved this to a seperate bug report, namely bug 352358.
Comment 13 Harish Krishnaswamy 2006-10-16 13:33:21 UTC
Committed to HEAD.