After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 307960 - [PATCH] Fix for gtkdoc parser errors in recent-files comment code
[PATCH] Fix for gtkdoc parser errors in recent-files comment code
Status: RESOLVED FIXED
Product: libegg
Classification: Other
Component: recent-files
unspecified
Other Linux
: High minor
: ---
Assigned To: Emmanuele Bassi (:ebassi)
Libegg maintenance
Depends on:
Blocks:
 
 
Reported: 2005-06-16 18:28 UTC by Dave Malcolm
Modified: 2005-12-31 00:40 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Stop gtk-doc from interpreting the licensing comment as a function header, and remove documentation of a void argument list (967 bytes, patch)
2005-06-16 18:29 UTC, Dave Malcolm
none Details | Review

Description Dave Malcolm 2005-06-16 18:28:38 UTC
While compiling a copy from cvs (in Conglomerate), the gtk-doc parser got these
parsing errors 

ERROR parsing comment block file : parameter expected -
../../src/recent-files/egg-recent-view-uimanager.c:5
ERROR parsing comment block file : parameter expected -
../../src/recent-files/egg-recent-view-uimanager.c:6
ERROR parsing comment block file : parameter expected -
../../src/recent-files/egg-recent-view-uimanager.c:7
ERROR parsing comment block file : parameter expected -
../../src/recent-files/egg-recent-view-uimanager.c:691

I'm about to attach a fix that cleaned it up for Conglomerate's copy.  Appears
to affect the upstream libegg HEAD in CVS.
Comment 1 Dave Malcolm 2005-06-16 18:29:52 UTC
Created attachment 47873 [details] [review]
Stop gtk-doc from interpreting the licensing comment as a function header, and remove documentation of a void argument list
Comment 2 Dave Malcolm 2005-06-16 18:30:49 UTC
Comment on attachment 47873 [details] [review]
Stop gtk-doc from interpreting the licensing comment as a function header, and remove documentation of a void argument list

(this was a patch to Conglomerate, but it should be applicable to the
appropriate path of CVS HEAD libegg)
Comment 3 James Willcox 2005-06-16 20:38:36 UTC
Commit
Comment 4 Geert Stappers 2005-06-17 10:40:52 UTC
What is the verbose version of

  Commit


???


I can live with only an update on the status flags of the patch,
(available flags are in the pick-list ( list of values ) in the attachment box )
but prefer to addition of some human words.

In other words:
Please take time to communicate with your peers.
Comment 5 James Willcox 2005-06-17 14:02:29 UTC
It means "The patch looks good, please go ahead and commit it to CVS".  I assume
Dave will mark the bug as fixed once that has occurred.
Comment 6 Sven Herzberg 2005-09-01 15:00:00 UTC
I asked emanuelle whether it is okay if i committed a similar patch some time
ago (i just left out the bonobo.c and the uimanager.c files as i didn't use -
and so didn't sync - them). I'm pretty sure that this patch is okay, so Dave,
please commit.
Comment 7 Emmanuele Bassi (:ebassi) 2005-12-31 00:40:08 UTC
finally, fixed in HEAD.

sorry for taking too long.