After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 307887 - [patch] Memleak in gconf-sources.c
[patch] Memleak in gconf-sources.c
Status: RESOLVED FIXED
Product: GConf
Classification: Deprecated
Component: gconf
CVS HEAD
Other Linux
: Normal normal
: ---
Assigned To: GConf Maintainers
GConf Maintainers
Depends on:
Blocks:
 
 
Reported: 2005-06-16 07:43 UTC by Aivars Kalvans
Modified: 2005-06-18 17:05 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
proposed patch (744 bytes, patch)
2005-06-16 07:45 UTC, Aivars Kalvans 		none Details | Review
small coding style changes (745 bytes, patch)
2005-06-16 07:50 UTC, Aivars Kalvans 		accepted-commit_now Details | Review

Description Aivars Kalvans 2005-06-16 07:43:56 UTC 
From http://www.gnome.org/~kmaraas/valgrind-logs-2005-06-09/gconfd-2

==14731== 140 bytes in 3 blocks are definitely lost in loss record 438 of 492
==14731==    at 0x1B909222: malloc (vg_replace_malloc.c:130)
==14731==    by 0x1BA18F55: g_malloc (gmem.c:137)
==14731==    by 0x1BA29531: g_strdup (gstrfuncs.c:91)
==14731==    by 0x1B9206D7: gconf_resolve_address (gconf-sources.c:63)
==14731==    by 0x1B920AAF: gconf_sources_new_from_addresses (gconf-sources.c:358)
==14731==    by 0x804E736: gconf_server_load_sources (gconfd.c:371)
==14731==    by 0x804FF1B: main (gconfd.c:777)

==14731== 33 bytes in 1 blocks are definitely lost in loss record 286 of 492
==14731==    at 0x1B909222: malloc (vg_replace_malloc.c:130)
==14731==    by 0x1BA18F55: g_malloc (gmem.c:137)
==14731==    by 0x1BA29531: g_strdup (gstrfuncs.c:91)
==14731==    by 0x1B9206D7: gconf_resolve_address (gconf-sources.c:63)
==14731==    by 0x1B920AAF: gconf_sources_new_from_addresses (gconf-sources.c:358)
==14731==    by 0x804E914: obtain_database (gconfd.c:1047)
==14731==    by 0x804EE1A: gconfd_get_database (gconfd.c:225)
==14731==    by 0x1B92EBA1: _ORBIT_skel_small_ConfigServer_get_database
(GConfX-common.c:128)
==14731==    by 0x1B96A303: ORBit_POAObject_invoke (poa.c:1141)
==14731==    by 0x1B96E31E: ORBit_OAObject_invoke (orbit-adaptor.c:284)
==14731==    by 0x1B95C869: ORBit_small_invoke_adaptor (orbit-small.c:835)
==14731==    by 0x1B96A5E8: ORBit_POAObject_handle_request (poa.c:1350)
==14731==    by 0x1B96AB7C: ORBit_POAObject_invoke_incoming_request (poa.c:1418)
==14731==    by 0x1B96CF78: ORBit_POA_handle_request (poa.c:1640)
==14731==    by 0x1B96E24E: ORBit_handle_request (orbit-adaptor.c:244)
==14731==    by 0x1B959B10: giop_connection_handle_input (giop-recv-buffer.c:1282)
==14731==    by 0x1B974070: link_connection_io_handler (linc-connection.c:1367)
==14731==    by 0x1B9759A7: link_source_dispatch (linc-source.c:159)
==14731==    by 0x1BA12E5D: g_main_context_dispatch (gmain.c:1933)
==14731==    by 0x1BA15C2D: g_main_context_iterate (gmain.c:2564)
==14731==    by 0x1BA1612E: g_main_loop_run (gmain.c:2768)
==14731==    by 0x804FFD6: main (gconfd.c:930)
Comment 1 Aivars Kalvans 2005-06-16 07:45:49 UTC 
Created attachment 47852 [details] [review]
proposed patch

Releases ->address
Comment 2 Aivars Kalvans 2005-06-16 07:50:41 UTC 
Created attachment 47853 [details] [review]
small coding style changes
Comment 3 Mark McLoughlin 2005-06-16 07:53:57 UTC 
This looks good. Please commit to the gnome-2-10 and HEAD branches. Thanks

(Mail me directly if you don't have a CVS account and we'll get you one)
Comment 4 Aivars Kalvans 2005-06-18 17:05:56 UTC 
2005-06-18  Aivars Kalvans <aivars.kalvans@inbox.lv>

	* gconf/gconf-sources.c (gconf_source_free): free ->address
	Fixes bug #307887