After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 307818 - "Save As..." button still shows an image with gtk-button-images=0
"Save As..." button still shows an image with gtk-button-images=0
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Documentation
2.6.x
Other Linux
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2005-06-15 17:27 UTC by Vincent Noel
Modified: 2005-06-16 12:51 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Vincent Noel 2005-06-15 17:27:04 UTC 
Put gtk-button-images=0 somewhere in your .gtkrc : all the images in stock
buttons are gone.
However the "Open this file with" dialog in epiphany still shows an image on the
"SAve As..." button.
Comment 1 Christian Persch 2005-06-16 12:21:56 UTC 
This is the code that creates the button:

button = gtk_button_new_with_label (_("_Save As..."));
image = gtk_image_new_from_stock (GTK_STOCK_SAVE_AS, GTK_ICON_SIZE_BUTTON);
gtk_button_set_image (GTK_BUTTON (button), image);

Shouldn't the gtk-button-images setting also apply to non-stock buttons? IMHO
yes, which would make this a gtk+ bug.
Comment 2 Christian Persch 2005-06-16 12:28:38 UTC 
Ok, I found that it works when you don't show the image yourself. I'm going to
fix that in ephy; but I think the docs should mention that you shouldn't do that.
Comment 3 Christian Persch 2005-06-16 12:39:43 UTC 
Fixed on HEAD and gnome-2-10 branch; transferring to gtk+ for the documentation
comment:

IMHO the documentation of gtk_button_set_image() should mention that you should
and need not show the image yourself.
Comment 4 Matthias Clasen 2005-06-16 12:51:09 UTC 
2005-06-16  Matthias Clasen  <mclasen@redhat.com>

	* gtk/gtkbutton.c (gtk_button_set_image): Add some more
	docs.  (#307818, Christian Persch)