GNOME Bugzilla – Bug 307704
patch for configure.in
Last modified: 2008-01-15 12:56:56 UTC
Distribution/Version: Gentoo here is a patch that incorporates some user requests for switches. please change them as needed if you think they should be changed. Thanks!
Created attachment 47782 [details] [review] configure patch
Have any precautions been taken to ensure that Gentoo users won't complain in the GIMP mailing lists, irc channel and bugzilla about missing features that are caused by this change?
This patch disables important features by default which is not an option. If the patch was changed so that the options are enabled by default and that one needs to specify --without-svg to explicitely disable it (why would someone want to do that?), then it might be accepted. I will close this report as WONTFIX. If you want to provide a new patch that incorporates my suggestions, feel free to reopen it.
What features are considered important enough to be on by default (and imply dependencies) ? I guess from comment #3 that would be svg only ? A trivial change to the patch would take care of that.
Created attachment 47797 [details] [review] enable svg support by default
gtkhtml2 is required for the help browser - the preferred way of viewing the help files lcms is required for color management, a feature many users ask for You're not doing the users a favor if you disable these by default.
We know what it is for. gtkhtml as a 'default on' dependency for just the help browser seems overdone, because pretty much any desktop system has a full-fledged browser these days. LCMS I don't know what is preferred by the gimp team (thats why i asked). The point is that we leave it to the user to decide what features they like and do not decide for them, for our package management it is bad to rely on autodetection of features (like happens now in the config) so we'd like to see that resolved and have no particular preferences for what should be default behaviour in this patch.
Gentoo folks are in no position to validly decide what defaults should be, given the frequency of people posting to the mailing list or coming on IRC saying "GIMP doesn't support TIFF" because the default USE flags don't pull it in. The only patch that will be accepted is to have all of these enabled by default.
Created attachment 47825 [details] [review] updated patch as requested All enabled by default now as requested in comment #9. Note that this request now will force lcms on by default for 'pure' tarball users and error out if it doesn't exist, as requested.
Wow, why is this so hard? The requirement is to simply maintain the current behavior that happens when people who run ./configure. Nowhere was there a request to error out on not finding lcms.
Created attachment 47826 [details] [review] aimed to please configure.in needs Well, I just try to come up with a patch that suits the requests. It gets hard when comments really are contradicting themselves (#8 & #10)
Sigh. There's no contradiction between #8 and #10. #8 didn't say anything about erroring out on not finding things, #8 is exactly what the current configure behavior does. There's nothing hard about this, you're inventing stuff to make it hard on your own.
The request I made in comment #3 was too use the --without configure flags here as we do for other plug-in dependencies such as mng. The patch would also have to touch the file INSTALL and document the new options.
Let's reopen this for the moment and hope that the reporter will come up with a nice patch that includes configure.in and INSTALL.
I would have happily accepted a proper patch that follows the style of the existing configure options and doesn't change the defaults. But it doesn't look as if the bug reporter is going to provide one, so I don't see much point in keeping this bug report around.
Created attachment 48692 [details] [review] gimp-2.2.8-configure-fix.patch Sven, sorry this took so long. Hopefully what you were requesting in comment #3 has been included / met. Thanks!
Created attachment 48694 [details] [review] gimp-2.2.8-INSTALL.patch patch against INSTALL
Committed, with naming and wording slightly tweaked, a whitespace fixed up. 2005-07-05 Manish Singh <yosh@gimp.org> * INSTALL * configure.in: Allow gtkhtml2, svg, and lcms features to be disabled explicitly at configure time. Based on patch from John N. Laliberte, fixes bug #307704.