After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 307459 - Can not rip the last track of CDs
Can not rip the last track of CDs
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins
0.8.9
Other All
: Normal normal
: 0.8.10
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2005-06-13 05:07 UTC by James Henstridge
Modified: 2005-06-13 10:02 UTC
See Also:
GNOME target: ---
GNOME version: 2.9/2.10

Attachments
gst-plugins-cdparanoia.patch (840 bytes, patch)
2005-06-13 09:44 UTC, James Henstridge 		accepted-commit_now Details | Review

Description James Henstridge 2005-06-13 05:07:59 UTC 
Please describe the problem:
When ripping a CD, everything goes fine until it hits the last track, at which
point it pops up a dialog saying:
  Sound Juicer could not extract this CD.
  Reason: Could not seek to track

Steps to reproduce:
1. insert a CD
2. deselect all tracks except for the last (this is just to trigger the error
quicker)
3. click extract


Actual results:
error message is displayed

Expected results:
the track should be ripped successfully

Does this happen every time?
yes

Other information:
My test system is an AMD64, and this is with the gnome-2.12 jhbuild moduleset,
built today.
Comment 1 James Henstridge 2005-06-13 09:44:18 UTC 
Created attachment 47701 [details] [review]
gst-plugins-cdparanoia.patch

Adjust the error check so that we can rip the last track.

If the disc has 10 tracks, and we seek to the last track, then we'll have
track=9 and endtrack=10.  The existing bounds check was 0 <= endtrack <
ntracks, which treated this as an error.
Comment 2 Ronald Bultje 2005-06-13 10:02:27 UTC 
applied.