After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 307426 - leak in gtkcalendar.c
leak in gtkcalendar.c
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Widget: Other
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2005-06-12 21:40 UTC by Kjartan Maraas
Modified: 2005-06-13 07:57 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
possible solution (601 bytes, patch)
2005-06-12 21:41 UTC, Kjartan Maraas
committed Details | Review

Description Kjartan Maraas 2005-06-12 21:40:32 UTC
Valgrind shows this:

==19189== 15392 (1248 direct, 14144 indirect) bytes in 26 blocks are definitely
lost in loss record 140 of 166
==19189==    at 0x1B909222: malloc (vg_replace_malloc.c:130)
==19189==    by 0x1BE0A1C6: cairo_create (cairo.c:109)
==19189==    by 0x1B9353CE: gdk_cairo_create (gdkcairo.c:46)
==19189==    by 0x1B9F95F7: calendar_paint_arrow (gtkcalendar.c:2190)
==19189==    by 0x1B9F9819: gtk_calendar_expose (gtkcalendar.c:2231)
==19189==    by 0x1BAB8644: _gtk_marshal_BOOLEAN__BOXED (gtkmarshalers.c:83)

Seems the calendar code is forgetting to call cairo_destroy()
Comment 1 Kjartan Maraas 2005-06-12 21:41:16 UTC
Created attachment 47675 [details] [review]
possible solution
Comment 2 Owen Taylor 2005-06-12 23:05:34 UTC
The patch is correct and fine to commit.
Comment 3 Kjartan Maraas 2005-06-13 07:57:31 UTC
Commited.