After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 307361 - please expose shoutcast stream metadata through playbin
please expose shoutcast stream metadata through playbin
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins
0.8.x
Other Linux
: Normal enhancement
: 0.8.11
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks: 304350
 
 
Reported: 2005-06-12 10:43 UTC by Jonathan Matthew
Modified: 2005-07-01 17:53 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
hackish patch (2.81 KB, patch)
2005-06-12 10:44 UTC, Jonathan Matthew
needs-work Details | Review
better patch (8.26 KB, patch)
2005-06-15 11:51 UTC, Jonathan Matthew
none Details | Review

Description Jonathan Matthew 2005-06-12 10:43:30 UTC
It'd be nice if playbin handled shoutcast stream metadata so applications
playing streams could display the current song title.  rhythmbox can do this
with its old playback pipeline, but it loses that ability when using playbin
instead.

I'll attach a patch that implements this.  It's a hack, but it might be a useful
starting point.  It sets the 'iradio-mode' property on the source element for
HTTP URLs (if it exists; the source element might not be a gnomevfssrc), and
forwards the resulting deep-notify signals from the source element, so you can
get the signal by attaching a signal handler to the playbin element.
Comment 1 Jonathan Matthew 2005-06-12 10:44:05 UTC
Created attachment 47640 [details] [review]
hackish patch
Comment 2 Ronald Bultje 2005-06-12 11:34:23 UTC
Also see #304350. I've already said I will not accept such a patch. I know it's
easiest, but really, iradio needs to use the standard tagging system in
gnomevfssrc, so that iradio tags can be read using the standard tagging system.
Comment 3 Jonathan Matthew 2005-06-15 11:51:18 UTC
Created attachment 47798 [details] [review]
better patch

makes gnomevfssrc emit tag events in addition to the current property
notifications.
Comment 4 Ronald Bultje 2005-06-15 21:15:14 UTC
Nice, thanks very much! I'll take this. So did you test this in Totem or so (or
Rhythmbox-CVS)?
Comment 5 Jonathan Matthew 2005-06-15 22:33:52 UTC
Most of my testing was just with gst-launch-0.8 -t playbin uri=http://stream/.
Both totem and rhythmbox require some work to support this properly.
I'll attach a patch for totem to #304350.
Comment 6 Jonathan Matthew 2005-06-16 11:10:13 UTC
Now I've tested this with rhythmbox too (cvs plus patch from #307899).
Comment 7 Ronald Bultje 2005-07-01 17:53:47 UTC
Applied, minus the bogus boolean in the struct, thanks.