After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 307231 - Badly wording on warning sentences
Badly wording on warning sentences
Status: RESOLVED FIXED
Product: gnome-applets
Classification: Other
Component: battery
git master
Other All
: Normal normal
: ---
Assigned To: gnome-applets Maintainers
gnome-applets Maintainers
Depends on:
Blocks:
 
 
Reported: 2005-06-11 03:29 UTC by Funda Wang
Modified: 2005-07-09 02:59 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
foo. (12.71 KB, patch)
2005-07-08 17:11 UTC, Allison Karlitskaya (desrt)
committed Details | Review

Description Funda Wang 2005-06-11 03:29:38 UTC
Current, warning explanation sentence is badly worded:
Warn when (percentage|time) remaining is less then ?? (percent|minutes)

If there won't be many variation of this sentence, please list them out, rather 
than use complicated expressions, such as:

_("Warn when percentage remaining is less than %d%%")
N_("Warn when time remaining is less than %d miniute",
   "Warn when time remaining is less than %d miniutes", miniutes)
Comment 1 Danielle Madeley 2005-06-11 06:01:19 UTC
Unfortunately this string is composed by three widgets, so we can't combine them
as a single translation. Unless we can word this any better. Or we could
implement the other thing discussed in bug #300642, however I quite like the
natural language approach.

Open to suggestions.
Comment 2 Funda Wang 2005-06-11 06:57:26 UTC
[V] Warn me when the battery will run out soon
    (*) Warn me if percentage remaining is less than [ ]% of total capacity
    ( ) Warn me if battery will run out in [ ] minutes

Or something like that, as long as there won't be any seperated words and 
setences.
Comment 3 Allison Karlitskaya (desrt) 2005-07-08 16:23:53 UTC
my suggestion from bug #300642

  [X] Warn me when battery charge drops to:

        [ 30 ]I [ Percent           v ]
                | Minutes Remaining   |

That's a vague attempt at ascii art for a spinbox and a combobox :) 

this would also fix the fact that the entire dialog box changes size when the
final label changes between minute/minutes/percent
Comment 4 Allison Karlitskaya (desrt) 2005-07-08 17:11:49 UTC
Created attachment 48836 [details] [review]
foo.

Patch to implement interface suggested in comment #3.

Haven't changed any of the logic as implemented by Davyd's original patch to
support dynamic percent/time-based warning levels -- only user interface code
has been changed.
Comment 5 Allison Karlitskaya (desrt) 2005-07-08 21:59:49 UTC
reminder (mostly to self): we're in string change announcement period.
Comment 6 Danielle Madeley 2005-07-09 02:18:43 UTC
Ok. Do it. I admit what I did was a little gratuitous. Remember to mail
gnome-i18n. I'm impressed that more translators didn't complain about this. Not
sure that 'Percent' and 'Minutes Remaining' should be capitalised.
Comment 7 Allison Karlitskaya (desrt) 2005-07-09 02:59:17 UTC
in HEAD.