GNOME Bugzilla – Bug 307195
Mark strings in operations as translatable.
Last modified: 2008-10-21 16:45:35 UTC
Add i18n support to Gegl Other information: see attachments gegl_i18n.patch gegl/po/Makefile.in gegl/po/Makefile.in.in gegl/po/POTFILES.in gegl/gegl/gegl-intl.h
Created attachment 47562 [details] [review] Patch for i18n support Gegl contains patch for: Makefile.am configure.in autogen.sh gegl-object.c gegl/gegl-object.h
Created attachment 47563 [details] Makefile.in for po dir create additional dir po under gegl root dir. /gegl/po/Makefile.in
Created attachment 47564 [details] Makefile.in.in for po dir file for po dir. /gegl/po/Makefile.in.in
Created attachment 47565 [details] POTFILES.in fro po dir file for po dir /gegl/po/POTFILES.in
Created attachment 47566 [details] i18n macros for gegl Macro /gegl/gegl/gegl-init.h
Created attachment 47567 [details] [review] Patch for i18n support Gegl Contents of patch /gegl/Makefile.am /gegl/configure.in /gegl/autogen.sh /gegl/gegl/gegl-object.c /gegl/gegl/gegl-object.h /gegl/gegl/gegl-init.c
You didn't attach gegl-i18n.h but gegl-init.h. But I think we should get away w/o gegl-init.h by using gi18n-lib.h from glib.
Created attachment 47600 [details] Missing file i18n Macros for gegl
>>by using gi18n-lib.h from glib. no problem this works
It would be nicer to actually depend on gi18n-lib.h from glib but IMO this patch should be committed and we can continue from there.
The only thing that needs translation in GEGL currently is the descriptions of the operations and their properties. This probably doesn't work right now, and might some more thought as well, if the plug-ins are to install their own translations, or perhaps translation packs for third party plug-ins?
How will we handle storing and distribution of translations for GEGL opertations? One single .po file for all the GEGL provided operations, and optional language packs for others? Or does GEGL operations distributed by third party developers install their own .po files?
How can they not use their own .po files? They are independent third-party developers and you might not even know about them. Either all strings used in the registration of a GEGL operation have to be translated when they are passed GEGL, or GEGL needs to provide a framework that allows modules to specify their translation domain and the location of the compiled message catalogs. But I guess you can get away with the much simpler solution of accepting translated strings. Or is there any reason why GEGL would need access to the untranslated strings?
Initial support for translation has now been added to GEGL, and a single operation has been flagged for translation.
More of the default operations should be translated. (the generated ops should probably be generated when the translation databases are).
Created attachment 114073 [details] [review] i18n strings for affine/ i've put "config.h" and <gi18n-lib.h> on top of the other includes here. Hope that is fine
Created attachment 114074 [details] [review] i18n strings for common/
Created attachment 114075 [details] [review] i18n strings for core/
Created attachment 114076 [details] [review] i18n strings for external/
Created attachment 114077 [details] [review] i18n strings for generated/
Created attachment 114079 [details] [review] i18n strings for workshop/**
A note for external/display.c (id=114076): the properties blurbed as 'private' are not included for translation. Also, this is the only op which has empty nicks. shouldn't matter, though.
Thank you, GEGL still has some needs in the build system to make the ops be fully translated. If that is the case a new bug should be opened about it. 2008-10-03 Øyvind Kolås <pippin@gimp.org> Applied patches from yahvuu at gmail.com for bug #307195 that marks strings in operation for translation. * operations/*/*.c:
Created attachment 120021 [details] PO dir adding patch This silly straightforward patch adds a 'po' directory, Makefile.in.in, POTFILES.in, LINGUAS and an initial ru.po.
po/Makefile.in.in should not be added to SVN. Instead configure.ac needs a call to IT_PROG_INTLTOOL(). And the files in the workshop folder should be removed from POTFILES.in and the workshop folder be added to POTFILES.skip instead.
Created attachment 121041 [details] new patch that adds po direfctory Removed po/Makefile.in.in, moved workshop files to po/POTFILES.skip, patched configure.ac