GNOME Bugzilla – Bug 306847
RFE: conversion option for CP932, EUC_JP_MS
Last modified: 2005-07-29 13:14:41 UTC
In most of current linux has the following additional Japanese iconv modules to have text compatibility with MS-Windows. - CP932 - EUCJP-MS These conversion option will improve handling Window's text in gedit. Please check following patch. diff -aNru gedit.org/gedit/gedit-encodings.c gedit/gedit/gedit-encodings.c --- gedit.org/gedit/gedit-encodings.c 2005-02-28 01:12:39.000000000 +0900 +++ gedit/gedit/gedit-encodings.c 2005-06-08 18:15:02.487747760 +0900 @@ -81,6 +81,8 @@ GEDIT_ENCODING_CP_866, GEDIT_ENCODING_EUC_JP, + GEDIT_ENCODING_EUC_JP_MS, + GEDIT_ENCODING_CP932, GEDIT_ENCODING_EUC_KR, GEDIT_ENCODING_EUC_TW, @@ -195,6 +197,11 @@ { GEDIT_ENCODING_EUC_JP, "EUC-JP", N_("Japanese") }, + { GEDIT_ENCODING_EUC_JP_MS, + "EUC-JP-MS", N_("Japanese") }, + { GEDIT_ENCODING_CP932, + "CP932", N_("Japanese") }, + { GEDIT_ENCODING_EUC_KR, "EUC-KR", N_("Korean") }, { GEDIT_ENCODING_EUC_TW,
<disclaimer>I'm pretty clueless about encodings</disclaimer> Your patch just adds these encodings to the list, but are you sure that they are really supported by g_convert etc? did you test? can you provide some test files?
*** Bug 306854 has been marked as a duplicate of this bug. ***
glibc 2.3.2 seems to support these encodings. paolo@elilix:~$ iconv --version iconv (GNU libc) 2.3.2 Copyright (C) 2003 Free Software Foundation, Inc. This is free software; see the source for copying conditions. There is NO warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. Written by Ulrich Drepper. paolo@elilix:~$ iconv -l | grep CP932 CP932// paolo@elilix:~$ iconv -l | grep JP CSISO2022JP// CSISO2022JP2// EBCDIC-JP-E// EBCDIC-JP-KANA// EUC-JP-MS// EUC-JP// EUCJP-MS// EUCJP-OPEN// EUCJP-WIN// EUCJP// ISO-2022-JP-2// ISO-2022-JP-3// ISO-2022-JP// ISO646-JP-OCR-B// ISO646-JP// ISO2022JP// ISO2022JP2// JP-OCR-B// JP// Since 2.3.2 has been released in 2003, I think most current distributions have it. Ubuntu has it. FC 2 has 2.3.3. I think we can commit this patch.
Created attachment 49934 [details] [review] Committed patch
Fixed in CVS HEAD. 2005-07-29 Paolo Maggi <paolo@gnome.org> Fixed bug #306847 (RFE: conversion option for CP932, EUC_JP_MS) * gedit-encodings.c: added CP932 and EUC_JP_MS to the list of known encodings. Patch by Kazuhiko Maekawa <Kazuhiko.Maekawa@Sun.COM>