After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 306673 - "Save calendar" freezes evo after missing file extension warning
"Save calendar" freezes evo after missing file extension warning
Status: RESOLVED FIXED
Product: evolution
Classification: Applications
Component: Calendar
2.4.x (obsolete)
Other All
: Normal normal
: ---
Assigned To: Dinesh Layek
Evolution QA team
: 316959 321578 322272 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2005-06-06 15:47 UTC by Jay Camp
Modified: 2013-09-10 14:03 UTC
See Also:
GNOME target: ---
GNOME version: 2.9/2.10

Attachments
fixes the bug (1.81 KB, patch)
2005-10-03 10:40 UTC, Dinesh Layek 		needs-work Details | Review
modified patch (2.68 KB, patch)
2005-10-27 11:16 UTC, Dinesh Layek 		none Details | Review
This was the patch committed. (2.68 KB, patch)
2005-11-16 04:58 UTC, Chenthill P 		none Details | Review

Description Jay Camp 2005-06-06 15:47:23 UTC 
Please describe the problem:


Steps to reproduce:
1. Try to save a calendar 
2. Enter a filename without any extension
3. Say No, to not continue
4. Append .ics to the filename and hit save again


Actual results:
All buttons become unresponse and the file is not saved.  The dialog must be
closed using the window manager.

Expected results:
Save as normal.

Does this happen every time?
Yes.

Other information:
Comment 1 C Shilpa 2005-06-10 04:43:06 UTC 
confirming bug. replicable even on 2.2.3
Comment 2 André Klapper 2005-08-30 13:26:41 UTC 
still valid in evolution-2.4.0.0.200508300318-0.snap.novell.11.1
Comment 3 André Klapper 2005-09-23 01:59:09 UTC 
*** Bug 316959 has been marked as a duplicate of this bug. ***
Comment 4 André Klapper 2005-09-23 02:02:33 UTC 
raising severity since people are running into this. i'd love to set this to
2.4.1 since people are running into this, feel free to retarget/future it.
Comment 5 Dinesh Layek 2005-10-03 10:40:40 UTC 
Created attachment 52970 [details] [review]
fixes the bug
Comment 6 Chenthill P 2005-10-27 07:55:51 UTC 
Running the dialog in a while loop is bad. You need to connect signals to the
corresponding buttons and listen to them. To improve the usablity, the extension
should be added by default, looking at the selected format from the combo box at
the bottom if the user does not include extension with the file name.

/* Free the handlers */
+	g_list_foreach (format_handlers, format_handlers_foreach_free, NULL);
+	g_list_free (format_ha
As this part is common now. The same code which is above
+			return;
could be removed as its redundant and "return" would not be needed then.
Comment 7 Dinesh Layek 2005-10-27 11:16:08 UTC 
Created attachment 53943 [details] [review]
modified patch
Comment 8 Dinesh Layek 2005-11-11 09:18:35 UTC 
Committed to both the branches
Comment 9 Chenthill P 2005-11-16 04:58:45 UTC 
Created attachment 54816 [details] [review]
This was the patch committed.
Comment 10 André Klapper 2005-11-16 11:59:04 UTC 
*** Bug 321578 has been marked as a duplicate of this bug. ***
Comment 11 André Klapper 2005-11-23 22:17:24 UTC 
*** Bug 322272 has been marked as a duplicate of this bug. ***