GNOME Bugzilla – Bug 305895
URL's (file:///) should be URL encoded.
Last modified: 2006-01-22 20:34:49 UTC
Please describe the problem: Currently, muine does not URL encode URL strings. This creates an unexpected behavior when the URL's given by Muine are processed by functions like URL.LocalPath. Filenames with % and ? in them are processed incorrectly, making functions that depend on them broken. I think the ideal solution would be to drop the "file://" on ISong.Filename (It's a file name not a URL) or to change ISong.Filename to ISong.URI and properly encode it. Drag and drop uri-lists too need to be handled properly. Steps to reproduce: Actual results: Expected results: Does this happen every time? Other information:
Created attachment 47087 [details] [review] Patch to src directory Okay, never mind on the Filename part, I was mistaken. As for the drag-and-drop URI problem, this is solved by making FileUtils.UriFromLocalPath symetrical to FileUtils.LocalPathFromUri
Created attachment 47090 [details] [review] Real Patch, should work this time. Accidentally converted tabs to spaces in previous patch.
This will be fixed properly once the switch to GnomeVfs# (in the works) is done.
In debugging MuineTagger, I found that GnomeVFS functions can't decode "file://" prepended paths that contain "#". If you rename a file to contain a "#" and try dragging it into nautilus from muine, it should copy, but nothing happens. Could we apply my patch as a temporary solution until the GnomeVfs# transition is complete?
I agree that this is a good intermediary solution. The file named '#.mp3' is certainly not handled properly with just prepending 'file://', as a simple test case. I've just commited this patch, we'll revisit this with Gnome.Vfs love soon though.