GNOME Bugzilla – Bug 305295
Add support for "invert selection".
Last modified: 2008-03-29 14:50:37 UTC
Please describe the problem: Previous versions of nautilus had invert selection but 2.10 is not having the feature Steps to reproduce: 1. Go to nautilus 2. Go to view 3. see the option there is no invert selection. Actual results: we dont find any invert selection. Expected results: Its better to have as an enhancement as invert selection Does this happen every time? yes Other information:
Usability crew, this sounds like a nice feature for a file manager, i.e. you could select all files except those matching a particular pattern. Was this removed for usability concerns, or was there another motive behind the removal?
I have no idea why this was removed (when was it added?). For what it's worth I always thought it was more useful to have "Select All" and "Select Invert" (Select Inverse?) than having "Select None".
FYI, I've already submitted [1] this but no review has happened yet. [1] http://mail.gnome.org/archives/nautilus-list/2005-July/msg00179.html
May be the Maintainer is busy for a while Christian.. Let us wait for a while to check any futher action takes place. Also I feel the maintainers have been change or what?
Something new on this ?
I hope that this feature is added again...
Created attachment 97795 [details] [review] 01_nautilus-invert-selection.patch (against 2.20.0) This patch adds an "Invert Selection" action in the Edit menu, just below Select Pattern, that inverts the current selection in both the icon and the tree view. (patch against Nautilus 2.20.0)
Let's hope this will get included
I like the patch(97795), it works great. Maybe the invert feature could be added to the gtk-tree widget. what do you think?
Created attachment 97987 [details] [review] 01_nautilus-invert-selection.patch (against 2.20.0) Small fix over the previous patch to disable the menu entry if there are no files /directories in the current folder (similar behavior as "select all" and "select pattern")
I think this is a good feature and we should try to get this in for 2.24! Amos, as your patch does not apply anymore against SVN trunk, could you update it so that someone can review and test that properly? (should be easy, as there's no GnomeVFS involved in this patch). Thanks!
Created attachment 107312 [details] [review] invert selection patch v2 I updated the patch to trunk myself, including some fixes to the previous Amos' version, works really fine in my testing.
Looks good to me, can go in after branch.
Nautilus has been branched, so I've committed this to trunk. Closing as FIXED, thanks Amos for the patch! 2008-03-29 Cosimo Cecchi <cosimoc@gnome.org> * libnautilus-private/nautilus-icon-container.c: (nautilus_icon_container_invert_selection): * libnautilus-private/nautilus-icon-container.h: * libnautilus-private/nautilus-view.c: (nautilus_view_invert_selection): * libnautilus-private/nautilus-view.h: * src/file-manager/fm-actions.h: * src/file-manager/fm-directory-view.c: (action_invert_selection_callback), (fm_directory_view_invert_selection), (real_update_menus), (fm_directory_view_class_init): * src/file-manager/fm-directory-view.h: * src/file-manager/fm-icon-view.c: (fm_icon_view_invert_selection), (fm_icon_view_class_init): * src/file-manager/fm-list-view.c: (fm_list_view_invert_selection), (fm_list_view_class_init): * src/file-manager/nautilus-directory-view-ui.xml: Add support for "Invert Selection". Patch by Amos Brocco <amos.brocco@unifr.ch>. (#305295).