After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 304795 - [ximagesrc] port to 0.9 [PATCH]
[ximagesrc] port to 0.9 [PATCH]
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other All
: High enhancement
: 0.10.3
Assigned To: Jan Schmidt
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2005-05-19 19:11 UTC by Lutz Mueller
Modified: 2006-05-03 21:45 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
ximagesrc.c ported to 0.9 (using GstBaseSrc) (7.54 KB, text/plain)
2005-05-19 19:13 UTC, Lutz Mueller
  Details
ximagesrc.h ported to 0.9 (using GstBaseSrc) (1.48 KB, text/plain)
2005-05-19 19:14 UTC, Lutz Mueller
  Details
gstximageplugin.c ported to 0.9 (1.55 KB, text/plain)
2005-05-19 19:14 UTC, Lutz Mueller
  Details
Necessary modifications to gst-plugins-base/sys/ximage/* (2.24 KB, patch)
2005-05-19 19:17 UTC, Lutz Mueller
none Details | Review
Necessary modifications to gstreamer/gst/base/gstbasesrc.c (1.70 KB, patch)
2005-05-19 19:19 UTC, Lutz Mueller
none Details | Review
updated ximagesrc (50.11 KB, patch)
2006-02-16 22:09 UTC, Jan Schmidt
none Details | Review

Description Lutz Mueller 2005-05-19 19:11:57 UTC
 
Comment 1 Lutz Mueller 2005-05-19 19:13:24 UTC
Created attachment 46652 [details]
ximagesrc.c ported to 0.9 (using GstBaseSrc)
Comment 2 Lutz Mueller 2005-05-19 19:14:02 UTC
Created attachment 46653 [details]
ximagesrc.h ported to 0.9 (using GstBaseSrc)
Comment 3 Lutz Mueller 2005-05-19 19:14:41 UTC
Created attachment 46654 [details]
gstximageplugin.c ported to 0.9
Comment 4 Lutz Mueller 2005-05-19 19:17:23 UTC
Created attachment 46655 [details] [review]
Necessary modifications to gst-plugins-base/sys/ximage/*
Comment 5 Lutz Mueller 2005-05-19 19:19:06 UTC
Created attachment 46656 [details] [review]
Necessary modifications to gstreamer/gst/base/gstbasesrc.c
Comment 6 Lutz Mueller 2005-05-19 19:23:23 UTC
The files I just uploaded are:

(1) Files that only exist in the 0.8 branch. I updated them and hope you will
include them in CVS HEAD, too.

(2) A diff against gstbasesrc.c: I hooked up the getcaps function (exists in the
header file, but has not been implemented)
Comment 7 Andy Wingo 2005-07-16 13:56:15 UTC
I had no idea this bug was here, submitter should be more aggressive with
gstreamer developers (and we should try to notice more)

Patch from comment #5 is obsolete, core has something like that now.

ximagesrc should probably be ported using PushSrc (which likely was not there
when the patch was made).

Otherwise things look good, cleanups for api changes would be appreciated, but
otherwise looks good for committing to CVS (with cleanups).
Comment 8 Zaheer Abbas Merali 2005-07-16 20:54:57 UTC
I have added xfixes (mouse pointer) support and luca has added xshm support to
the 0.8 version.  Those changes should be added to this patch, maybe also this
should be ported to PushSrc as wingo says.

I am adding xdamage support as we speak and that should speed it up.
Comment 9 Tim-Philipp Müller 2005-10-19 11:29:47 UTC
Re-assigning to gst-plugins-base module for now, not sure where it's gonna end
up in the end:

<__tim> thomasvs: has ximagesrc.[ch] been lost in the plugins split-up, or has
it not been decided where it goes yet?
<thomasvs> __tim: both iirc - I didn't know how well it worked yet, and I
somehow prefered to not put it in the ximagesink plugin
<__tim> thomasvs: that's why the plugin has been renamed to ximage ;)
<thomasvs> __tim: right - I prefer not to do that
<__tim> k
<thomasvs> or at least, not put them in the same plug-in
Comment 10 Tim-Philipp Müller 2005-10-19 11:34:17 UTC
Bug #306292 might also be relevant
Comment 11 Andy Wingo 2005-11-14 12:09:29 UTC
Plugins cannot be added to -base at this point. ximagesrc would have to go into
another module. Probably the best way to shar code would be to have separate
copies of ximageutil.[ch]. Changing product to gst-plugins-good.
Comment 12 Julien MOUTTE 2005-12-18 21:24:18 UTC
ximagesrc has to be ported to gst-plugins-bad, i m not going to use any shared file with that plugin.
Comment 13 Lutz Mueller 2005-12-19 12:34:01 UTC
Is anyone currently working on porting the plugin to CVS HEAD?
Comment 14 Julien MOUTTE 2005-12-19 14:08:57 UTC
I ll look at it, yes.
Comment 15 Jan Schmidt 2006-01-31 10:52:41 UTC
did this get ported at any point?
Comment 16 Lutz Mueller 2006-01-31 19:15:40 UTC
I could not find it in gst-plugins-[ugly,bad,good,base]. 
Comment 17 Jan Schmidt 2006-02-16 22:07:36 UTC
Attaching an updated patch that applies against CVS head of gst-plugins-base for 0.10. This patch includes the XFixes and XDamage support from 0.8, but it isn't quite correct, because it applies the XDamage changes to whichever XImage is retrieved from the bufferpool.

with gst-launch ximagesrc ! fakesink, that will always be the most recent buffer, and things work right, but gst-launch ximagesrc ! queue ! fakesink is going to look interesting.

Comment 18 Jan Schmidt 2006-02-16 22:09:12 UTC
Created attachment 59530 [details] [review]
updated ximagesrc
Comment 19 Jan Schmidt 2006-02-20 21:54:58 UTC
Committed the patch to CVS, we'll do any further work there.