GNOME Bugzilla – Bug 304714
Password Cache page HIG fixes
Last modified: 2005-07-18 13:38:32 UTC
Removed deprecated frames from the 'Cache encryption passphrase in memory' checkbox. Made 'Start seahorse-agent' and 'Session Properties' links blue and fixed spacing. Other information:
Created attachment 46627 [details] [review] patches glade file
Cool. As far as the blue links... Could we do something like vino-preferences does with it's link? ie: underlined and a different mouse cursor?
Just another note, mostly for myself. After applying this fix, we may need to put a note in about how if you unselect cache_authorize then it'll clear the cache right then and there. See: http://cvs.gnome.org/bonsai/cvsquery.cgi?branch=&dir=seahorse&who=nnielsen&date=explicit&mindate=2005-05-18%2022:21&maxdate=2005-05-18%2022:23
Blue links done by Flavio daCosta. To do it seahorse-prefs-cache.c had to be patched too. I have attached patches. The other attached glade patch is nullified.
Created attachment 49110 [details] [review] Patch to add blue links and cursor change
Created attachment 49112 [details] [review] Correct version of patch to fix blue links and cursor change
Created attachment 49113 [details] [review] fix to glade file to clean up seahose-daemon page
I like the changes the glade patch makes. I'm not sure why decend_widgets_and_find_label() is needed. In Glade, I was able to individually select the button labels and assign them names. If that will work with glade_xml_get_widget(), I would prefer that to the current solution. If that won't work, I'd like there to be only one return statement in that function. Assign the label to a pointer and return that at the bottom.
Created attachment 49276 [details] [review] glade and prefs-cache patch in 1 One patch to rule them all. There was a problem with duplicate labels in the glade file that caused the odd hack around. It should be good now.
Patch didn't apply cleanly to 0.8.0 branch so only committed to HEAD.
Yes, that's probably best. The stable branch should only be for bug fixes at this point.