GNOME Bugzilla – Bug 304548
Hovering over an pressed ToggleButton makes it look like not pressed
Last modified: 2005-06-17 18:34:00 UTC
NOTE this bug is a bit theme dependent, but improving the GTKToggleButton would solve this bug for all themes immediately. (I use the clearlooks theme) If you hover over a toggle button the button becomes bright gray. It doesn't matter if the button is in pressed state or in a non pressed state. Because of this effect it is very difficult to see if a button is in pressed on non pressed state if you hover over it
Created attachment 46924 [details] [review] Patch removing prelight from active toggle buttons By removing prelight from an active/enabled togglebutton. The difference between a n active and non-active toggle is larger.
ping. Could you review the patch? Thanks
Created attachment 47287 [details] [review] Correct patch Oops, of course the prelight has to remain for check buttons and radio buttons etc.
Created attachment 47296 [details] [review] OK now really the correct patch
Created attachment 47346 [details] [review] Improved patch I think this patch is a better than the previous one, because if now one of children of togglebutton overides the button->enter method it will still work
Ok, as you said, this is theme dependend. So I think the best way is to fix the theme/engine. I personaly wouldn't like to loose the prelight, since the theme that I am using has a nice prelight for toggle buttons.
Is the prelight in your theme different for pressed and non pressed toggle buttons? The gtk code suggests to me that that is not possible. What's the theme you use?
Hmm, you got a point here. Yeah, it is impossible to define a different prelight colors for the toggle button. I am using the eXperience theme. For prelight it draws all buttons as before, but with an orange bevel around it. I think that this works good. Well, it is possible to just use another color inside the engine, and an engine can - by ignoring the prelight - do the same as you suggest, and just use the active/normal colors. The check in the engine will have to use the shadow_type to determine how to draw the button. It will be IN for ACTIVE GtkToggleButtons, and OUT for NORMAL ones. So IMHO this should be changed in the engine/theme.
It should also be possible to check the "active" property, or call gtk_toggle_button_get_active ().
This is related to bug #301651
OK I discovered that the newest clearlooks theme (cvs of today) changes somehow the prelight for enabled togglebuttons. So it's possible to change it in a theme. Closing this bug