GNOME Bugzilla – Bug 303809
dropping a link from firefox to nautilus that points to redirected address
Last modified: 2008-09-06 19:07:52 UTC
Distribution: Debian 3.1 Package: nautilus Severity: normal Version: GNOME2.10.0 2.10.0 Gnome-Distributor: Ubuntu Synopsis: Nautilus crash after dropping a link from firefox to a nautilus window Bugzilla-Product: nautilus Bugzilla-Component: general Bugzilla-Version: 2.10.0 BugBuddy-GnomeVersion: 2.0 (2.10.0) Description: Steps to reproduce the crash: 1. go to http://www.ctan.org/tex-archive/help/Catalogue/entries/figflow.html in firefox 2. drag one of the linked .zip files to a nautilus window 3. click down load in the nautilus dialog 4 crash Expected Results: the file to be downloaded How often does this happen? several files had downloaded happily, i am not sure if there was anything different with the on the crashed nautilus. Additional Information: i am not sure whether it was a http or ftp link that did this, but i am pretty sure that i had previously download both with this method. Mozilla/5.0 (X11; U; Linux ppc; en-GB; rv:1.7.6) Gecko/20050506 Firefox/1.0 (Ubuntu package 1.0.2) upto date hoary system. uname -a Linux titania 2.6.10-5-powerpc #1 Tue Apr 5 12:44:32 UTC 2005 ppc GNU/Linux Debugging Information: Backtrace was generated from '/usr/bin/nautilus' Using host libthread_db library "/lib/libthread_db.so.1". [Thread debugging using libthread_db enabled] [New Thread 16384 (LWP 6417)] [New Thread 32769 (LWP 6435)] [New Thread 16386 (LWP 6436)] [New Thread 32771 (LWP 6447)] [New Thread 49156 (LWP 6448)] [New Thread 65541 (LWP 6449)] [New Thread 81926 (LWP 6451)] [New Thread 376839 (LWP 11601)] [New Thread 19021832 (LWP 5008)] [New Thread 19038217 (LWP 5009)] [New Thread 19054602 (LWP 5010)] [New Thread 19070987 (LWP 5011)] [New Thread 19136524 (LWP 6020)] 0x0f98c110 in waitpid () from /lib/libpthread.so.0
+ Trace 59493
------- Bug moved to this database by unknown@bugzilla.gnome.org 2005-05-11 15:41 UTC ------- Unknown version 2.10.0 in product nautilus. Setting version to "2.10.x".
had a closer look. seems that the link i dragged was not pointing to an actual file due to a typo on that page. dragging the link http://theory.uwinnipeg.ca/scripts/CTAN/macros/latex/contrib/isotope/.zip to nautilus and clicking download seems to be reproduceble. just cliking on the link gives a 550 failed to change directory error. nautilus should handle this http reply and give a nice error.
I can reproduce with head, the stack goes like this:
+ Trace 59658
Thread 6 (Thread -1225684048 (LWP 26940))
The server seems to send a redirect to a ftp url. That leads to resolve_alias returning (null), which is fed into g_str_equal from http_session_uri_equal.
this could be a dupe of 306246 which has been fixed.
*** Bug 316036 has been marked as a duplicate of this bug. ***
still exists in gnome 2.12.1 (the version in ubuntu 5.10)
For the record: this is also reproducable with Gnome 2.10.0
Created attachment 53441 [details] [review] adds limited support for redirects from http to another protocol The patch adds awareness of foreign protocols to http_get_file_info, http_transfer_start, and do_read in modules/http-neon-method.c. This is just enough to support the use case that triggered the crash. The patch is to CVS HEAD. I'm new to gnome hacking and I've been away from C for years, so I'm expecting comments :-) Two things to look into: 1) When testing the patch by dragging http://www.omg.org/cgi-bin/apps/doc?@formal/02-11-05.pdf to the desktop, there's a period of a couple of seconds where nautilus doesn't draw the desktop. Presumably it's busy logging in to omg.org's FTP server. I don't know what to do about that. 2) I don't have a clear understanding of the security picture here. Do bad things happen if gnome-vfs is asked for http://example.com/ and example.com issues a redirect to file:///etc/shadow? Should the code accept only non-local protocols? Or a whitelist of protocols?
Thanks for your efforts! I like the way you tackle the issue, but I'm not sure how some generic handler is meant to figure out the actual target URI, because we *do* want to access the "ftp" URI.
*** Bug 380294 has been marked as a duplicate of this bug. ***
gnome-vfs has been deprecated and superseded by gio/gvfs since GNOME 2.22, hence mass-closing many of the gnome-vfs requests/bug reports. This means that gnome-vfs is NOT actively maintained anymore, however patches are still welcome. If your reported issue is still valid for gio/gvfs, please feel free to file a bug report against glib/gio or gvfs. @Bugzilla mail recipients: query for gnome-vfs-mass-close to get rid of these notification emails all together. General further information: http://en.wikipedia.org/wiki/GVFS Reasons behind this decision are listed at http://www.mail-archive.com/gnome-vfs-list@gnome.org/msg00899.html