After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 303637 - changes to/fromselected from/to unselected should be reported for focused table line
changes to/fromselected from/to unselected should be reported for focused tab...
Status: RESOLVED FIXED
Product: gnopernicus
Classification: Deprecated
Component: srcore
unspecified
Other Linux
: Normal normal
: ---
Assigned To: remus draica
remus draica
AP1
Depends on:
Blocks: 301924
 
 
Reported: 2005-05-10 08:31 UTC by remus draica
Modified: 2005-05-18 10:28 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
proposed patch (4.94 KB, patch)
2005-05-10 11:07 UTC, remus draica 		reviewed Details | Review
reworked patch (4.94 KB, patch)
2005-05-17 07:59 UTC, remus draica 		accepted-commit_now Details | Review

Description remus draica 2005-05-10 08:31:10 UTC 
When the focused table line changes its state, this change should be reported by
gnopernicus.

Bug inspired from bug #301924.
Comment 1 remus draica 2005-05-10 11:07:39 UTC 
Created attachment 46281 [details] [review]
proposed patch
Comment 2 bill.haneman 2005-05-12 11:48:55 UTC 
Comment on attachment 46281 [details] [review]
proposed patch

does this only produce output when the item whose selection is changing is also
FOCUSSED? 

I am concerned that this patch will produce side-effects for some UI situations
- have you tested it with JavaSwing, with StarOffice tables, and with other
kinds of selectable objects?  What if an item changes its state to or from
SELECTED without the user having been directly responsible, that is if it's not
focussed or active?
Comment 3 remus draica 2005-05-13 09:58:00 UTC 
>+	else if (srle_has_type (event, SRL_EVENT_STATE_SELECTED))
>+	    rv = srle_acc_has_role (event, SPI_ROLE_TABLE_CELL);

These lines are in 
   if (srle_is_for_focus() || srle_is_for_watch ()).

So, the state change is present only for current focussed line.
Comment 4 bill.haneman 2005-05-16 13:34:20 UTC 
Comment on attachment 46281 [details] [review]
proposed patch

I don't think the check for SPI_ROLE_TABLE_CELL in SRLow.c is correct, since
cells won't always have this role.

Also, I think some state-change notification is needed for selected/unselected
in default.xml as well as in verbose.xml.
Comment 5 remus draica 2005-05-16 13:44:54 UTC 
>Also, I think some state-change notification is needed for selected/unselected
>in default.xml as well as in verbose.xml.

It is present in both files.
Comment 6 bill.haneman 2005-05-16 14:20:46 UTC 
I missed the selected/unselected change in default.xml, thanks.

Can you remove the check for SPI_ROLE_TABLE_CELL?  I think it's incorrect.
Comment 7 remus draica 2005-05-17 07:59:39 UTC 
Created attachment 46528 [details] [review]
reworked patch
Comment 8 remus draica 2005-05-18 10:28:23 UTC 
Comment on attachment 46528 [details] [review]
reworked patch


Patch committed.