After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 303573 - Exceptions raised in a child watch handler are silently swallowed
Exceptions raised in a child watch handler are silently swallowed
Status: RESOLVED FIXED
Product: pygobject
Classification: Bindings
Component: gobject
2.9.0
Other Linux
: Normal normal
: ---
Assigned To: Nobody's working on this now (help wanted and appreciated)
Python bindings maintainers
Depends on:
Blocks:
 
 
Reported: 2005-05-09 15:42 UTC by Mark McLoughlin
Modified: 2006-01-09 14:13 UTC
See Also:
GNOME target: ---
GNOME version: 2.9/2.10

Attachments
test-mainloop.py (377 bytes, text/plain)
2005-05-09 15:43 UTC, Mark McLoughlin 		  Details
pygtk-dont-silently-swallow-exceptions-in-child-watch-handlers.patch (1.62 KB, patch)
2005-05-09 15:45 UTC, Mark McLoughlin 		none Details | Review
pygtk-dont-silently-swallow-exceptions-in-child-watch-handlers.patch (3.88 KB, patch)
2005-05-09 17:08 UTC, Mark McLoughlin 		none Details | Review

Description Mark McLoughlin 2005-05-09 15:42:32 UTC 
Distribution/Version: Fedora Core

If the callback passed to gobject.child_watch_add() raises an exception, no
traceback is printed.

Patch and test cases provided below
Comment 1 Mark McLoughlin 2005-05-09 15:43:39 UTC 
Created attachment 46242 [details]
test-mainloop.py
Comment 2 Mark McLoughlin 2005-05-09 15:45:38 UTC 
Created attachment 46243 [details] [review]
pygtk-dont-silently-swallow-exceptions-in-child-watch-handlers.patch
Comment 3 Johan (not receiving bugmail) Dahlin 2005-05-09 15:55:19 UTC 
Looks good. 

Can you please adapt your test to use unittest and add it as
testsuite/test_mainloop.py? (so make check/distcheck catches this).
Comment 4 Mark McLoughlin 2005-05-09 17:08:23 UTC 
Created attachment 46248 [details] [review]
pygtk-dont-silently-swallow-exceptions-in-child-watch-handlers.patch
Comment 5 Johan (not receiving bugmail) Dahlin 2005-05-09 20:03:11 UTC 
Thanks, checked in.

(I modified test_mainloop.py slightly)
Comment 6 Mark McLoughlin 2005-05-10 06:13:56 UTC 
You forgot the change to include test_mainloop.py in Makefile.am
Comment 7 Johan (not receiving bugmail) Dahlin 2005-05-10 12:32:51 UTC 
That seems strange, since it shows up here:

http://cvs.gnome.org/viewcvs/gnome-python/pygtk/tests/Makefile.am?r1=1.16&r2=1.17

Are you really running latest cvs?
Comment 8 Mark McLoughlin 2005-05-10 12:56:35 UTC 
My bad, I just didn't see that it had moved up the list :-)

(I wondered how distcheck had managed to pass for you :-)