GNOME Bugzilla – Bug 303221
[PATCH]crash when using a detached menu after closing the associated diagram
Last modified: 2005-05-09 11:13:45 UTC
Distribution: Debian 3.1 Package: dia Severity: normal Version: GNOME2.8.3 0.94 Gnome-Distributor: Debian Synopsis: Crashes when using a detached menu after closing the diagram. Bugzilla-Product: dia Bugzilla-Component: general Bugzilla-Version: 0.94 BugBuddy-GnomeVersion: 2.0 (2.8.1) Description: Description of the crash: When one detaches the file menu from a diagram, and closes that diagram, the menu related to that diagram stays open. After that, an action on that menu crashes dia. Steps to reproduce the crash: 1. Detach a menu from the diagram. 2. Click close on that menu. 3. Click close on that menu again. Expected Results: Dia crashes. How often does this happen? Always Additional Information: Debugging Information: Backtrace was generated from '/usr/bin/dia-gnome' (no debugging symbols found) Using host libthread_db library "/lib/tls/libthread_db.so.1". (no debugging symbols found) `system-supplied DSO at 0xffffe000' has disappeared; keeping its symbols. (no debugging symbols found) (no debugging symbols found) (no debugging symbols found) (no debugging symbols found) (no debugging symbols found) (no debugging symbols found) (no debugging symbols found) (no debugging symbols found) (no debugging symbols found) (no debugging symbols found) (no debugging symbols found) (no debugging symbols found) (no debugging symbols found) (no debugging symbols found) (no debugging symbols found) (no debugging symbols found) (no debugging symbols found) (no debugging symbols found) (no debugging symbols found) (no debugging symbols found) (no debugging symbols found) (no debugging symbols found) (no debugging symbols found) (no debugging symbols found) (no debugging symbols found) (no debugging symbols found) (no debugging symbols found) (no debugging symbols found) (no debugging symbols found) (no debugging symbols found) (no debugging symbols found) (no debugging symbols found) (no debugging symbols found) (no debugging symbols found) (no debugging symbols found) (no debugging symbols found) (no debugging symbols found) (no debugging symbols found) (no debugging symbols found) (no debugging symbols found) (no debugging symbols found) (no debugging symbols found) [Thread debugging using libthread_db enabled] [New Thread 1088354112 (LWP 4848)] (no debugging symbols found) (no debugging symbols found) (no debugging symbols found) (no debugging symbols found) (no debugging symbols found) (no debugging symbols found) (no debugging symbols found) (no debugging symbols found) (no debugging symbols found) (no debugging symbols found) (no debugging symbols found) (no debugging symbols found) (no debugging symbols found) (no debugging symbols found) (no debugging symbols found) (no debugging symbols found) (no debugging symbols found) (no debugging symbols found) (no debugging symbols found) (no debugging symbols found) (no debugging symbols found) (no debugging symbols found) (no debugging symbols found) (no debugging symbols found) (no debugging symbols found) (no debugging symbols found) (no debugging symbols found) (no debugging symbols found) (no debugging symbols found) (no debugging symbols found) (no debugging symbols found) (no debugging symbols found) (no debugging symbols found) (no debugging symbols found) (no debugging symbols found) (no debugging symbols found) (no debugging symbols found) (no debugging symbols found) (no debugging symbols found) (no debugging symbols found) (no debugging symbols found) (no debugging symbols found) (no debugging symbols found) (no debugging symbols found) (no debugging symbols found) (no debugging symbols found) (no debugging symbols found) (no debugging symbols found) (no debugging symbols found) (no debugging symbols found) (no debugging symbols found) (no debugging symbols found) (no debugging symbols found) (no debugging symbols found) (no debugging symbols found) (no debugging symbols found) (no debugging symbols found) (no debugging symbols found) (no debugging symbols found) (no debugging symbols found) (no debugging symbols found) 0x40b4c4ee in __waitpid_nocancel () from /lib/tls/libpthread.so.0
+ Trace 59246
Thread 1 (Thread 1088354112 (LWP 4848))
------- Bug moved to this database by unknown@bugzilla.gnome.org 2005-05-06 09:08 UTC -------
hmmm unique stack trace. Strange I cannot reproduce the crash using your steps. Dia 0.94 , Debian testing as well Maybe your system/libs are in an inconsistant state? Try apt-get update upgrade .
I'll do the upgrade during the night, in the meanwhile, I tried same steps on Fedora Core 2, dia 0.92.2 and it works (that is, it crashes), if it's any help.
That is version 0.92.2 on FC2? Is that your version on Debian as well? 0.94 is the latest. Please try the latest.
No, my version on Debian is (and was) 0.94, version on FC2 was 0.92.2 (was crashing), but I have just installed 0.94 on FC2, and this one also crashes. Debian is currently updating, so I'll send the report when it finishes.
Ok, debian is now upgraded, dia still crashes. My precise steps, from the start of dia: dia starts and opens a default diagram, I right-click it, to get the menu for that diagram, select file menu, and detach it. Using that file menu, I close the diagram, the menu stays open (there are now no diagrams), I click close on that menu again. segmentation fault.
Created attachment 46113 [details] [review] Patch fixing crash on closing nonexisting diagram from detached menu Crashes on CVS-HEAD (slackware 10.1 + dropline gnome 2.10.1). Quickfix patch attached.
Ah - confirmed. Misunderstood you before. thanks for the patch Radek. +HIGH priority +MAJOR severity target 0.95
Christian: thanks for looking into this but at least I use the bugzilla fields different. Although you seem to follow http://developer.gnome.org/projects/bugsquad/triage/steps.html for 'Crasher Bugs", I wouldn't have changed the fields at all with such a simple work around (Don't do it;)). The 'target' should only be set if it is for sure that the target version wont have the bug in it, usually set when a fix is in cvs. Radek: thanks for the patch. I've done it different to be consitent with the rest of commands.c. Check for valid parameters before calling functions on them. 2005-05-08 Hans Breuer <hans@breuer.org> * app/command.c : some people insist to close diagrams already closed using tear-off menus. Maybe we should add a dialog "Do you want to call Dr. Watson now?". If there is no diagram to close anymore just do nothing, fixes bug #303221 * app/display.c(ddisplay_close) : use g_return_if_fail(ddisp != NULL); Calling this with no display to close is a pathological case.
ok changing patch to commited. thanks for reminding me about the target milestone field Hans.