After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 303117 - Gstreamer plugins 0.8.8 musepack plugin build fails
Gstreamer plugins 0.8.8 musepack plugin build fails
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins
0.8.8
Other Linux
: Normal normal
: 0.8.9
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2005-05-05 11:03 UTC by Matthias Saou
Modified: 2005-05-18 10:37 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
fix (2.50 KB, patch)
2005-05-10 05:56 UTC, Ronald Bultje
none Details | Review

Description Matthias Saou 2005-05-05 11:03:18 UTC
Distribution/Version: Fedora Core Development

Apparently, the gst-plugins 0.8.8's musepack plugin doesn't rebuild against
libmusepack 1.1 (nor 1.1.1, the latest). Here is the failed build's relevant
output :

[...]
 gcc -DHAVE_CONFIG_H -I. -I. -I../.. -I../../gst-libs -I../../gst-libs
-D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -pthread -I/usr/include/gstreamer-0.8
-I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/include/libxml2
-DGST_DISABLE_DEPRECATED -Wall -O2 -g -pipe -Wp,-D_FORTIFY_SOURCE=2 -fexceptions
-m32 -march=i386 -mtune=pentium4 -fasynchronous-unwind-tables -MT
libgstmusepack_la-gstmusepackreader.lo -MD -MP -MF
.deps/libgstmusepack_la-gstmusepackreader.Tpo -c gstmusepackreader.c  -fPIC
-DPIC -o .libs/libgstmusepack_la-gstmusepackreader.o
gstmusepackreader.c:93: error: syntax error before 'gst_musepack_reader_seek'
gstmusepackreader.c:94: warning: return type defaults to 'int'
gstmusepackreader.c:130: error: syntax error before 'gst_musepack_reader_canseek'
gstmusepackreader.c:131: warning: return type defaults to 'int'
gstmusepackreader.c: In function 'gst_musepack_init_reader':
gstmusepackreader.c:141: warning: assignment from incompatible pointer type
gstmusepackreader.c:144: warning: assignment from incompatible pointer type
make[3]: *** [libgstmusepack_la-gstmusepackreader.lo] Error 1
make[3]: Leaving directory `/usr/src/rpm/BUILD/gst-plugins-0.8.8/ext/musepack'

This is on Fedora Core Development, with gcc4.
Comment 1 Randy McMurchy 2005-05-06 03:52:30 UTC
Though my errors are somewhat different, I'm sure they are related:

gcc -DHAVE_CONFIG_H -I. -I. -I../.. -I../../gst-libs -I../../gst-libs 
-D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -pthread 
-I/usr/include/gstreamer-0.8 -I/usr/include/glib-2.0 
-I/usr/lib/glib-2.0/include -I/usr/include/libxml2 -DGST_DISABLE_DEPRECATED 
-Wall -g -O2 -MT libgstmusepack_la-gstmusepackreader.lo -MD -MP 
-MF .deps/libgstmusepack_la-gstmusepackreader.Tpo -c gstmusepackreader.c  
-fPIC -DPIC -o .libs/libgstmusepack_la-gstmusepackreader.o
gstmusepackreader.c:93: error: parse error before "gst_musepack_reader_seek"
gstmusepackreader.c:94: warning: return type defaults to `int'
gstmusepackreader.c:130: error: parse error before "gst_musepack_reader_canseek"
gstmusepackreader.c:131: warning: return type defaults to `int'
gstmusepackreader.c: In function `gst_musepack_init_reader':
gstmusepackreader.c:141: warning: assignment from incompatible pointer type
gstmusepackreader.c:144: warning: assignment from incompatible pointer type
make[3]: *** [libgstmusepack_la-gstmusepackreader.lo] Error 1
make[3]: Leaving directory `/home/rml/build/gst-plugins-0.8.8/ext/musepack'
make[2]: *** [all-recursive] Error 1
make[2]: Leaving directory `/home/rml/build/gst-plugins-0.8.8/ext'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/home/rml/build/gst-plugins-0.8.8'
make: *** [all] Error 2
Comment 2 Ronald Bultje 2005-05-10 05:56:07 UTC
Created attachment 46268 [details] [review]
fix

This patch updates the plugin to the new API in 1.2. I'll apply it when 1.2 is
released. Patch contributed via email by Benoit Amiaux
<benoit.amiaux@laposte.net>.
Comment 3 Ronald Bultje 2005-05-18 10:37:16 UTC
Applied.