After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 302962 - audioconvert improvements
audioconvert improvements
Status: RESOLVED OBSOLETE
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
git master
Other Linux
: Normal enhancement
: 0.10.x
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2005-05-04 09:32 UTC by Wouter Paesen
Modified: 2006-03-02 20:04 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Conversion improvements (35.10 KB, patch)
2005-05-04 09:33 UTC, Wouter Paesen 		none Details | Review
cleanup of the previous patch (30.82 KB, patch)
2005-05-30 13:22 UTC, Wouter Paesen 		none Details | Review
Memleak fix + normalisation (42.96 KB, patch)
2005-06-01 22:13 UTC, Wouter Paesen 		none Details | Review

Description Wouter Paesen 2005-05-04 09:32:32 UTC 
I added some code that takes the decisions on how to convert from input format
to internal format and from internal format to output format out of the
conversion loop.  This also makes it possible to use liboil for cpu optimized
conversion.

A patch will be uploaded
Comment 1 Wouter Paesen 2005-05-04 09:33:08 UTC 
Created attachment 46007 [details] [review]
Conversion improvements
Comment 2 Ronald Bultje 2005-05-18 10:47:29 UTC 
Since it involves oil, let's see what Dave thinks...
Comment 3 David Schleef 2005-05-18 17:22:59 UTC 
We're not making liboil a required dependency in 0.8, so any usage needs to be
wrapped in #ifdef HAVE_LIBOIL and have alternates.  No comment yet on the rest
of the patch.
Comment 4 Wouter Paesen 2005-05-30 13:22:52 UTC 
Created attachment 47031 [details] [review]
cleanup of the previous patch

I cleaned up the patch to apply cleanly to gst-plugins-0.8.9.  I also removed
any references to liboil for now.
Comment 5 Wouter Paesen 2005-06-01 22:13:36 UTC 
Created attachment 47117 [details] [review]
Memleak fix + normalisation

Previous patch introduced a memleak.  This one also adds normalisation of
signals to full scale.
Comment 6 Ronald Bultje 2005-07-02 10:36:03 UTC 
I'm not against refactoring, but I don't think we should do this for 0.8. It
doesn't actually improve performance, and adds a lot of new code, and has some bugs:
* doesn't handle width != depth
* I see some possible memory overflows in the (u)int24 reading/writing code

Here's my proposal:
* add the liboil code back in, assuming it improves performance.
* apply this to 0.9 only, so we have enough time to test it and can assume
liboil to be there. 0.8 continues to work just fine, slightly less-performing,
which is OK since audio is practically not really a bottleneck anyway.
* at some point maybe consider applying to 0.8 if there's some HAVE_OIL macros
around it.
Comment 7 Andy Wingo 2005-07-16 13:20:31 UTC 
Wouter, would you mind working up a patch for 0.9's audioconvert? Using liboil
is fine as long as it is readable.
Comment 8 Andy Wingo 2006-01-27 12:46:22 UTC 
Hi Wouter,

Any interest to get this patch ported against audioconvert in current CVS?
Comment 9 Wouter Paesen 2006-01-27 13:35:26 UTC 
Interest yes. As soon as my schedule(r) has a spare timeslot available i'll try to work something out.
Comment 10 Wim Taymans 2006-03-02 20:04:52 UTC 
A similar optimisation was commited to audioconvert a long time ago. closing.