After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 302743 - gnome_vfs_uri_equal speed enhancement
gnome_vfs_uri_equal speed enhancement
Status: RESOLVED FIXED
Product: gnome-vfs
Classification: Deprecated
Component: URI handling
cvs (head)
Other All
: Low enhancement
: ---
Assigned To: gnome-vfs maintainers
gnome-vfs maintainers
Depends on:
Blocks:
 
 
Reported: 2005-05-02 17:12 UTC by Olivier Sessink
Modified: 2005-11-08 19:24 UTC
See Also:
GNOME target: ---
GNOME version: 2.9/2.10


Attachments
Proposed patch (HEAD). (617 bytes, patch)
2005-05-07 22:48 UTC, Christian Neumair
none Details | Review

Description Olivier Sessink 2005-05-02 17:12:43 UTC
Version details: I checked 2.9.3
Distribution/Version: Debian

because a GnomeVFSURI is reference counted, there is quite a possibility that
two uri's that are compared are actually the same.

First line in the function should therefore be

if (a == b) return TRUE;
Comment 1 Christian Neumair 2005-05-06 21:31:18 UTC
Thanks for filing this bug bug report. This suggestion would indeed be a
worthwhile enhancement.
Comment 2 Christian Neumair 2005-05-07 22:48:39 UTC
Created attachment 46151 [details] [review]
Proposed patch (HEAD).

Trivial patch attached.
Comment 3 Kjartan Maraas 2005-11-08 19:24:07 UTC
Commited to both branches.