GNOME Bugzilla – Bug 302223
Main Menu Button has wrong proportions
Last modified: 2005-07-21 09:59:05 UTC
Please describe the problem: Up to the 2.8 panel, I was able to have a non-square main-menu button. This is not possible in 2.10 anymore which is obviously a feature that shouldn't have been dropped. Since it is talking about icons and the panel, this bug is kinda related to bug #74274 but afterall the issue is different. Steps to reproduce: 1. 2. 3. Actual results: Expected results: Does this happen every time? Other information:
What do you mean by this really? Could you make the button itself non-square or just add a new non-square icon to it? Care to elaborate a bit?
Ehm, simply if I add a non square image, it will be scaled to fit into a square the size of the panel height. Previously this was different and It would be scaled so that the height of the button would fit the height of the panel, while the width was restricted to the panelwidth and not the panel height. Maybe I didn't quite get your question right, but AFAIK the button is no button as such but just the icon.
Are there any plans to resolve this or is it just going to be this way for now on? If you need a little more elaboration, I would be happy to reiterate the problem that David has brough up. Thanks.
how do change the icon?
how do you change the icon?
Pretty easy: Just create a gnome-main-menu.svg in your icon theme. But this is kinda unrelated to the bug, I guess. I _do_ change it to a non-square icon, but it's forced onto this tiny squared space.
> Are there any plans to resolve this or is it just going to be this way > for now on? Yes, there are plans to resolve this. We just need time to look at the problem...
Created attachment 48492 [details] [review] rectangular-menu-buttons-again.diff If we get the patch in bug #309258 into gdk-pixbuf, then this attached patch fixes the bug. Would need to also require in configure.in the version of gtk+ which adds the feature
It's in GTK+ 2.7.1. I'm not sure if we can depend on it yet, though...
2005-07-21 Mark McLoughlin <mark@skynet.ie> Fix for #302223 requires gdk_pixbuf_new_from_file_at_size() to support passing -1 for width/height. * configure.in: require gtk+ 2.7.1. 2005-07-21 Mark McLoughlin <mark@skynet.ie> Fixes bug #302223 - rectangular buttons get scaled incorrectly. * panel-util.[ch]: (panel_load_icon): add desired_width and desired_height arguments to specify the dimensions the icon can be scaled to. Passing -1 for either is interpreted as "not constrained", so e.g. you'd pass -1 for width on a horizontal panel. * button-widget.c: (button_widget_reload_pixbuf): * panel-addto.c: (panel_addto_make_pixbuf): * panel-run-dialog.c: (panel_run_dialog_set_icon): Update callers for API change above.