After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 302112 - Add authorize preference to prompt
Add authorize preference to prompt
Status: RESOLVED FIXED
Product: seahorse
Classification: Applications
Component: general
0.7.x
Other Linux
: Normal enhancement
: ---
Assigned To: Seahorse Maintainer
Seahorse Maintainer
Depends on:
Blocks:
 
 
Reported: 2005-04-27 00:31 UTC by Adam Schreiber
Modified: 2005-04-27 04:06 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
see bug description (3.03 KB, patch)
2005-04-27 00:34 UTC, Adam Schreiber 		needs-work Details | Review
see bug description (3.17 KB, patch)
2005-04-27 01:32 UTC, Adam Schreiber 		none Details | Review
One last time with the right function (1.39 KB, patch)
2005-04-27 02:33 UTC, Adam Schreiber 		reviewed Details | Review
New and Shiny (3.44 KB, patch)
2005-04-27 03:07 UTC, Adam Schreiber 		committed Details | Review

Description Adam Schreiber 2005-04-27 00:31:51 UTC 
ENH - Add a check box tied to gconf for "/apps/seahorse/agent/cache_authorize"
to the authorize passphrase prompt.
Comment 1 Adam Schreiber 2005-04-27 00:34:22 UTC 
Created attachment 45723 [details] [review]
see bug description

Adding code from libseahorse/seahorse-prefs-cache.c may not be the best way to
do this.  Do we need to make these methods more exposed to allow this kind of
tie in, or is this a very rare thing?
Comment 2 Stef Walter 2005-04-27 01:31:30 UTC 
You can use the seahorse_check_button_control_new function to build a checkbox
nicely linked to a boolean gconf entry.
Comment 3 Adam Schreiber 2005-04-27 01:32:16 UTC 
Created attachment 45725 [details] [review]
see bug description

Whose apparently out of sync with cvs?	This guy----^  Now with a patch that
builds against current.
Comment 4 Adam Schreiber 2005-04-27 02:33:05 UTC 
Created attachment 45726 [details] [review]
One last time with the right function
Comment 5 Stef Walter 2005-04-27 02:45:15 UTC 
Looks good. I'd just suggest two things to change if you think they make sense:

- Use the text "Always ask me before using a cached passphrase". The 'always'
  makes it clearer to the user that he/she is changing a setting.
- I'd suggest moving all the SETTING_XXXX gconf keys into seahorse-agent.h now 
  that we're using them from more than one place.
Comment 6 Adam Schreiber 2005-04-27 03:07:30 UTC 
Created attachment 45727 [details] [review]
New and Shiny

Changed text, moved #defines to seahorse-agent.h
Comment 7 Stef Walter 2005-04-27 04:06:53 UTC 
Awesome. Checked into CVS.