After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 302018 - Nautilus crashes when user focuses on icon area and hits <ctrl>+top buttons
Nautilus crashes when user focuses on icon area and hits <ctrl>+top buttons
Status: RESOLVED FIXED
Product: nautilus
Classification: Core
Component: File and Folder Operations
2.6.x
Other Linux
: Normal major
: ---
Assigned To: Nautilus Maintainers
Nautilus Maintainers
AP1
Depends on:
Blocks:
 
 
Reported: 2005-04-26 09:44 UTC by Gary Johnston
Modified: 2005-05-02 21:12 UTC
See Also:
GNOME target: ---
GNOME version: 2.5/2.6


Attachments
Patch fixes the bug. (1.57 KB, patch)
2005-04-28 07:35 UTC, Vinay M R
none Details | Review

Description Gary Johnston 2005-04-26 09:44:58 UTC
Using latest Linux internal build, gnome nautilus 2.6.1 and gnome gok 1.0.3

Steps to reproduce:
* start gok
* open up nautilus (click "Documents" on the desktop)
* create a new folder in documents folder
* open the new folder and make sure the focus is on the icon area
* Go to Compose and click on Ctrl + top button (any of the 5 purple buttons at
the top that you select a predicted word from)

Nautilus will crash.  Crash occurs on dwell and autoscanning modes.
Comment 1 Vinay M R 2005-04-28 07:29:07 UTC
Easiest way to reproduce the bug without involving Ally/GOK is:
1)open up nautilus (click "Documents" on the desktop)
2)create a new folder in documents folder
3)open the new folder and press Ctrl+Space.

Nautilus will crash.
Comment 2 Vinay M R 2005-04-28 07:33:46 UTC
Ctrl+Space is used to toggle the selection state of the current icon. When user
press Ctrl+Space, it will try to toggle selection on an icon in empty folder.
Hence set_keyboard_focus() asserts leading to nautilus crash. 

So, in keyboard_space function, check if an icon is found, before trying to
alter focus.

Attaching a small patch.
Comment 3 Vinay M R 2005-04-28 07:35:47 UTC
Created attachment 45772 [details] [review]
Patch fixes the bug.
Comment 4 Martin Wehner 2005-05-02 21:12:21 UTC
Committed on both branches - Thanks Vinay.