After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 301943 - patches to fix compilation warnings
patches to fix compilation warnings
Status: RESOLVED FIXED
Product: gnome-utils
Classification: Deprecated
Component: general
2.10.x
Other Linux
: High normal
: ---
Assigned To: gnome-utils Maintainers
gnome-utils Maintainers
: 172958 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2005-04-25 17:18 UTC by Stanislav Brabec
Modified: 2005-06-16 15:03 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
gnome-utils-include.patch (1.63 KB, patch)
2005-04-25 17:19 UTC, Stanislav Brabec 		needs-work Details | Review
gnome-utils-printf.patch (501 bytes, patch)
2005-04-25 17:19 UTC, Stanislav Brabec 		committed Details | Review
gnome-utils-void.patch (3.19 KB, patch)
2005-04-25 17:22 UTC, Stanislav Brabec 		committed Details | Review
gnome-utils-gcc4.patch (898 bytes, patch)
2005-04-25 17:23 UTC, Stanislav Brabec 		committed Details | Review
gnome-utils-include2.patch (3.42 KB, patch)
2005-06-16 14:36 UTC, Stanislav Brabec 		committed Details | Review

Description Stanislav Brabec 2005-04-25 17:18:44 UTC 
Attached patches fixes most warnings, which can maybe cause problems on 64-bit
platforms.
Comment 1 Stanislav Brabec 2005-04-25 17:19:12 UTC 
Created attachment 45660 [details] [review]
gnome-utils-include.patch
Comment 2 Stanislav Brabec 2005-04-25 17:19:30 UTC 
Created attachment 45661 [details] [review]
gnome-utils-printf.patch
Comment 3 Stanislav Brabec 2005-04-25 17:22:18 UTC 
Created attachment 45664 [details] [review]
gnome-utils-void.patch

Patch from Gary Ekker.
Comment 4 Stanislav Brabec 2005-04-25 17:23:33 UTC 
Created attachment 45665 [details] [review]
gnome-utils-gcc4.patch

Patch defines new return value for invalid parameters instead of returning
random value.
Comment 5 Olav Vitters 2005-04-25 17:28:05 UTC 
heh, just got a midair collision asking you to change the summary :)
Comment 6 Stanislav Brabec 2005-04-25 17:35:17 UTC 
Additional note to gnome-utils-include.patch: It seems, that linux/fs.h is not
needed anymore. For older kernels, it is enough to define _LINUX_AUDIT_H_ before
including it, for newer kernels, it is not sufficient and including this file fails.
Comment 7 Kjartan Maraas 2005-05-16 22:00:52 UTC 
*** Bug 172958 has been marked as a duplicate of this bug. ***
Comment 8 Vincent Noel 2005-06-14 22:11:36 UTC 
Ok, I have applied all the patches except the first one (attachment 45660 [details] [review]) that
does not apply cleanly.
Could you please check if the patch is still relevant and create a new version ?
Thanks !
Comment 9 Stanislav Brabec 2005-06-16 14:36:54 UTC 
Created attachment 47865 [details] [review]
gnome-utils-include2.patch

First patch is not relevant - all gfloppy problems were fixed.
New patch addresses remaining implicit declaration issues in gdict and logview.
Comment 10 Vincent Noel 2005-06-16 15:03:43 UTC 
Ok, I committed your last patch.
Thanks for all the work !