After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 301726 - "Create Web Album" does not use relative paths for images
"Create Web Album" does not use relative paths for images
Status: RESOLVED FIXED
Product: gthumb
Classification: Other
Component: general
2.6.x
Other Linux
: Normal critical
: ---
Assigned To: Paolo Bacchilega
Paolo Bacchilega
Depends on:
Blocks:
 
 
Reported: 2005-04-23 18:28 UTC by Simon
Modified: 2005-12-24 13:53 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
fix a bug preventing correct relative path calculations (390 bytes, patch)
2005-04-23 20:38 UTC, Christophe Bisière
none Details | Review

Description Simon 2005-04-23 18:28:51 UTC
Distribution/Version: Ubuntu

- Select some images
- Go to Tools->Create Web Album
- Create an album
- Open the index file in you browser
- Select an image to open the detail view of that image
- Click again on that image to view the image alone
- The url of that image is not relative, and therefore, when you upload the
directory with your web album to your web server, that image will not show up.
Comment 1 Christophe Bisière 2005-04-23 20:38:46 UTC
Created attachment 45596 [details] [review]
fix a bug preventing correct relative path calculations

Without this fix, get_path_relative_to_dir(filename, destdir) is called with
filename == "/xxx/yyy/..." and destdir == "file:///xxx/zzz/...", preventing a
correct relative path calculation.

The fix relies on the assumption that "filename" in
catalog-web-exporter.c:
  static ImageData *
  image_data_new (const char *filename)
never starts with "file://".
Is it correct?

Christophe
Comment 2 Paolo Bacchilega 2005-12-24 13:53:14 UTC
fixed in current CVS, thanks.