After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 301158 - 2 casts of buf in the gst_ximagesink_chain function (ximagesink plugin)
2 casts of buf in the gst_ximagesink_chain function (ximagesink plugin)
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins
git master
Other Linux
: Normal trivial
: 0.8.9
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2005-04-19 07:58 UTC by Vincent Torri
Modified: 2005-04-19 11:25 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Vincent Torri 2005-04-19 07:58:54 UTC 
In gst_ximagesink_chain (ximagesink plugin), buf is casted 2 times (lines 1097
and 11112)
One of them is useless, imho
Comment 1 Tim-Philipp Müller 2005-04-19 11:25:46 UTC 
There's not run-time type checking involved in GST_BUFFER(data), so the cast is
basically free. I guess it's not very pedagogical though to cast using
GST_BUFFER() and then later to check whether it's an event with GST_IS_EVENT().
That's done in plenty of plugins though, unfortunately. Anyway, fixed in CVS,
thanks.

Cheers
 -Tim