GNOME Bugzilla – Bug 301151
Please add keyboard shortcut for deleting images from disk
Last modified: 2008-06-30 11:57:40 UTC
Having to right-click on the image and selecting "Delete From Drive" get tiresome when I want to quickly browse through my "raw" images and get rid of all the bad ones. Please add a keyboard shortcut to bring up the confirmation dialog box, as this would make it quicker to use. I suggest <backspace> or <ctrl>-<k> as the shortcut keys, unless there are better alternatives to keep f-spot consistent with other applications. It would be nice if the confirmation dialog box contained a smal version of the image to make it easier to verify that the correct image is being selected for deletion. Other information: This is Debian Bug reported by Petter Reinholdtsen <pere@hungry.com> and located at http://bugs.debian.org/305306
I think that instead marking images should be made easier. And, ha, I just discovered that you can use Ctrl+Space to mark an image and Ctrl+Cursor to move around. I'd suggest having the space key bound to toggle marking is an improvement since this is easier to discover.
Marking as enhancement, updating version. I think shift-delete is a more common way of providing this.
I do not think we should add a keyboard shortcut by default to this. Possibility to activate it from f-spot preferences maybee. Otherwise it is to easy to delete pictures by misstake. (Don't know how many times I have managed to hit the (send email) shortcut by misstake...) An easier/safer way perhaps is to make it easy to attach a tmp tag to a number of pictures (CTRL-T?), and then at the end, select all tmp'd tagged photos, and then delete them all (after verifying...)
Perhaps even coming up with a popup window forcing user to type "YeS" (capital sensitive!) to really ensure that we will not delete any images by misstake. This especially goes for the original. Perhaps not needed for the different versions?
Then after you type "YeS", you have to enter your root password, and after that you have to type Y for each file you have chosen to delete, and after that they will move into a Trash folder, and after that you have to empty the trash, and after that say "Yes" to empty, and then they will be gone, unless you undelete them! How about NOT, let's just use shift-delete and not babysit users! It's the same combination used in Nautlius and almost all file managers, and they don't ask for all this silly confirmation so f-spot shouldn't either. And Bengt, did you not bother reading the message above about how to mark messages, esentially doing exactly what you were describing? It works well. Anyway, I hope shift-del is added to remove photos from disk.
Ryan, I take it you did not like my small suggestion/comment. :) Anyway, Nautilus and all other file managers (which normal users will use, which means my mother) have a OUPS feature. It is called WasteBasket. F-Spot do not have this feature. But by all means, please delete all your wedding photos by misstake (Selecting Yes instead of No due to distraction, your kid touches the wrong button, just plain stupidity etc). If you ask me, I would prefere to have quite a lot of seat belts if you are talking about permanently removing my pictures. Especially my originals. But that is only me. If you read the description, it states more or less only click yes to delete with a small icon of the picture. Which is the normal standard way, and is used by other functions in F-Spot. Which makes it way easy to delete by accident, since how often do you actually check something you have done 1000 times before? Perhaps it is only me, but for sure it has happend a few times that I press Yes, when I know I should press No. Yes, I know, should never happend. It's your responsibility etc etc. And yes, we must have backups as well. I also understand I am in minority here, but I still stand by my comment. Way to easy to delete something that should not be deleted. And how many of the end users do take backups?
Created attachment 65292 [details] [review] Patch adding delete shortcut Not too much to say: this patch allows you to "delete pictures from drive" when pressing shift-delete, delete still only removes them from catalog. No special yes/no dialog, behaviour is exactly the same as when you would select "Delete from drive" from the popup menu
The patch should probably add the accel to the menu items as well.
Created attachment 71544 [details] [review] Resolving comments New version of the patch. This one adds both the "Delete" (for removing) and the "Shift-Delete" (for deleting) accelerators to the menu items.
Created attachment 71647 [details] [review] previous patch was no good same as previous version, but this time better executed.
>>6 Shift-Delete bypasses wastebasket in Nautilus, but asks for confirmation. The number of files to delete is reported in the confirmation dialogue. Delete without shift moves directly to wastebasket without confirmation. Implementing both Delete and Shift-Delete would be best for consistency with Nautilus. This would require also implementing bug 353056
*** Bug 360384 has been marked as a duplicate of this bug. ***
Created attachment 76954 [details] [review] applies cleanly to cvs head updated version to apply cleanly to cvs head as of 21/11/06
*** Bug 378857 has been marked as a duplicate of this bug. ***
In bug 378857 I advocated making "Delete from drive" the behaviour for the delete key, as I never remove items from the catalogue but often want to delete photos as I sort through them after pulling them off my camera. My ideal workflow would be to view each image at full size, decide if I want it, if not press the delete key, click yes to a confirmation and it's gone. Instead I currently remember the ones I want, then go to "Browse", select all the unwanted ones and batch delete them. Alternatively, Mike Robinson's suggestion would work well for me -- I don't fundamentally care whether a photo is in the wastebasket or *really* deleted, and if moving to the wastebasket saves a confirmation then perhaps that is a better option.
I also like Mike Robinson's suggestion, and would recommend that this bug be superseded by bug #353056: Having Delete move photo to Gnome's Trash, and Shift-Delete erasing the photo permanently. This would make F-Spot behaviour consistent with Nautilus behaviour.
*** Bug 493090 has been marked as a duplicate of this bug. ***
We really need this little keyboard shortcut, plus I think it should be enabled in full screen view as well. it's pretty annoying using fspot to browse my raw withouth being able to erase the file. when you work with photography, usually you shot alot of pics at the same subject. obviouslly just some images gets "promoted" so you need to trash a lot of files.
*** Bug 523283 has been marked as a duplicate of this bug. ***
fixed in r4087 and r4088 by Rubenv.