After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 301093 - Crashes in impl_save
Crashes in impl_save
Status: RESOLVED FIXED
Product: epiphany
Classification: Core
Component: General
git master
Other Linux
: Normal normal
: ---
Assigned To: Epiphany Maintainers
Marco Pesenti Gritti
: 306429 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2005-04-18 17:18 UTC by Sjoerd Simons
Modified: 2005-06-05 13:15 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Use the right type when getting a property (580 bytes, patch)
2005-04-18 17:21 UTC, Sjoerd Simons 		none Details | Review

Description Sjoerd Simons 2005-04-18 17:18:21 UTC 
Distribution/Version: Debian experimental

Go to a page with a favicon and witness a crash (happens on my ppc, not on my
i386).. Patch attached with a fix
Comment 1 Sjoerd Simons 2005-04-18 17:21:26 UTC 
Created attachment 45406 [details] [review]
Use the right type when getting a property

impl_save gets the max_size (among other things) from the EphyEmbedPersist
object.. It passes a 32 bit (on ppc32) variable to it to store the value, but
the stored value is 64 bit. Which causes some memory curruption, resulting in
the crash i was seeing
Comment 2 Christian Persch 2005-04-18 19:09:51 UTC 
Fixed in cvs (HEAD and gnome-2-10); thanks for the patch!
Comment 3 Sjoerd Simons 2005-04-19 09:30:25 UTC 
In the changelog you mention that it's a crash on 64 bit archs.. That's wrong,
my powerpc is definately 32 bit :).. The property that's being retrieved is a 64
bit value (gint64), which was being stored in a 32 bit variable (what long is on
32 bit archs).. So probably it wouldn't even crash on 64 bit archs where long is
64 bit :)
Comment 4 Christian Persch 2005-04-19 11:35:26 UTC 
Right, sorry. Just a thinko while writing the changelog entry :)
Comment 5 Christian Persch 2005-06-05 13:15:26 UTC 
*** Bug 306429 has been marked as a duplicate of this bug. ***