After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 301028 - .xcf text layers no longer editable as text on re-open
.xcf text layers no longer editable as text on re-open
Status: RESOLVED FIXED
Product: GIMP
Classification: Other
Component: General
2.2.x
Other All
: Normal minor
: 2.2
Assigned To: GIMP Bugs
GIMP Bugs
Depends on:
Blocks:
 
 
Reported: 2005-04-18 02:56 UTC by Dan Larson
Modified: 2008-01-15 12:52 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
A tiny test image (.xcf.gz) demonstrating the problem (1.18 KB, application/x-gzip)
2005-04-18 17:41 UTC, Michael Schumacher
Details

Description Dan Larson 2005-04-18 02:56:55 UTC
Distribution/Version: XP Home

1: Create a new image
2: Create a text layer
3: Save the file in .xcf format
4: Close the new image
5: Re-open the image

If it works on your machine the same way it does mine, the text layers will no 
longer be represented as text, therefore the text cannot be changed.

I first noticed the bug when I upgraded from 2.0.5 to 2.2.4 a few weeks ago. I 
recently downloaded 2.2.6 to test it again, and the same thing still happened. 
I created a new file with 2.2.6 to negate the possibility of cross-version 
errors, and still the text was no-longer text when I opened the file again.

I'm running GIMP version 2.2.6 with GTK+ 2.6.4 on the Windows XP Home 
operating system (pre Service Pack 2).

If you cannot recreate this error, please let me know. It won't be the first 
time my machine has done somthing strange on it's own.
Comment 1 Michael Schumacher 2005-04-18 07:47:33 UTC
The text layers are still editable. They lost their icon in the layers dialog,
though, and if you try to edit them, a warning dialog pop up and tells you that
the text layer has been transformed or edited, and that you will lose the
changes if you edit the text.
Comment 2 Sven Neumann 2005-04-18 16:18:02 UTC
That would still be a bug but I cannot reproduce the problem here. Tried with
gimp-2.2.3, gimp-2.2.7 and the CVS version and all show text layers in an XCF
files as text layers.

Can you please attach a small XCF file with one or two text layers that triggers
the problem for you?
Comment 3 Michael Schumacher 2005-04-18 17:41:07 UTC
Created attachment 45407 [details]
A tiny test image (.xcf.gz) demonstrating the problem

This happens in 2.2.6, 2.2.7 and current CVS.
Comment 4 Sven Neumann 2005-04-18 18:27:41 UTC
If I load this image (using CVS HEAD or gimp-2-2), I see an editable text layer
in the layers dialog. I cannot reproduce your problem.
Comment 5 Raphaël Quinet 2005-04-18 18:52:19 UTC
Same for me.  The image shows editable text layers.  I suspect that the problem
is specific to the Windows port.
Comment 6 Sven Neumann 2005-04-18 19:03:34 UTC
There shouldn't be anything Windows-specific about this code though.
Comment 7 Dan Larson 2005-04-18 20:55:33 UTC
Thank you, Michael Schumacher.

I tested your description, and I can duplicate the behavior. I was able to 
click on the text layer and re-edit it by converting it back to a text layer. 
I never even thought to try because the layer-stack preview looked like the 
basic raster preview.

Thank you all for your assistance.
Dan
Comment 8 Sven Neumann 2005-04-18 21:41:14 UTC
If this problem is reproducible on Win32 or on other platforms, it's still a
major problem.
Comment 9 Dan Larson 2005-04-19 22:51:31 UTC
It is only a minor annoyance, and a simple work-around is available. According 
to the bug-reporting guidelines, a problem with a work-around should be labled 
as minor. Therefore when I was informed of the work-around, I changed the 
severity.

I'll agree that it would be better if it were fixed, and it in and of itself 
represents an apparent major loss of functionality, it is not exactly what it 
appeared to be.

I assumed that's what you ment, Sven, when you said "it's still a major 
problem." If you were meaning something else (refering to something other than 
my changing the severity rating), I apologize for the incorrect assumption. If 
you would like me to change it back, please let me know.

Thanks again,
Dan
Comment 10 Michael Natterer 2005-04-19 23:22:10 UTC
Fixed in both branches:

2005-04-20  Michael Natterer  <mitch@gimp.org>

	* app/xcf/xcf-load.c (xcf_load_layer): initialize text_layer_flags
	with 0 so it doesn't contain random garbage if the text layer
	flags in the XCF have default values (are not saved at all). Fixes
	bug #301028. Initialize other stuff too for the sake of sanity.