GNOME Bugzilla – Bug 300984
Import from Gallery Installs
Last modified: 2018-07-12 00:05:05 UTC
I would like to be able to import images from gallery installs. I would connect and it would list the galleries which are available. From there, I could have it download the full size images and import automatically while assigning tags.
I'm pretty sure the gallery code already has the ability to do this, the major impediment at this point is coming up with a reasonable ui. Shouldn't be to hard though.
I've created a patch against current CVS to add support for importing images from Gallery. So far I've only tested it against Gallery 1, I don't have any Gallery 2 galleries to test against. I would be interested in adding support, so if anyone has G2 and lets me know how it works that would be great. In general its fairly complete but there are a couple of issues to be worked out. Issues: The options UI is still somewhat rough. It isn't integrated into the Import dialog. The code is setup so it should be able to, but there are currently some issues. The main one is that the code assumes that the images are available locally. This could be dealt with by downloading all the images in Prepare(), and then do the import in Step(). It doesn't update the main view when the import is done. I haven't figured out how to do this yet, but for now clicking on the tags and forcing a refresh works.
Created attachment 55039 [details] [review] Add support for gallery import This patch contains the patch in #321507.
Created attachment 60848 [details] [review] new gallery import patch (not commit ready) *** Not ready for commit *** OK, here is an updated version which takes advantage of the gallery 2 support added earlier. It separates the import type specfic options into an area that changes based on the import source selected. The UI will need to be reworked as its too tall to fit on my screen (1280x800). As I said, this isn't ready for commit but is here for comment: 1. Do people like this more than the separate dialog / wizard style I sent to the list? 2. UI redesign ideas to make everything fit. (One thing I've thought of is to move the image preview off to a column on the right and have everything else in the left column) 1) Apply from the src dir and rerun autoconf 2) Add account through export to Gallery dialog 3) Run Import and you Gallery accounts should show up as sources.
Created attachment 62216 [details] [review] new gallery import patch Ok, I've done some more work on the previous patch. Going back to the single import UI has been received much better than the multiple dialog wizard style from before. It needs more testing before I would call it release ready, but I need some help testing it. Screenshots here: http://www.monnahan.com/f-spot/new_import
This worked great and saved a heck of a lot of time moving from Gallery to Flickr along with keeping all my photos organized. Would include in trunk, or make it an easy to install plugin. One issue though, a lot of my gallery's had movies in them and this crashed F-spot because the width and height didn't exist. Maybe skip movie files?
Created attachment 70896 [details] [review] Update to apply to 20060814 CVS Quick-n-dirty update of the patch to apply to current CVS. I'll see if I can clean it up to some acceptable state in the next couple of weeks.
Created attachment 70901 [details] [review] my latest version (may not apply to CVS) This was the last version I was working on with acs. But this was a few months ago so it may not apply cleanly to CVS. This is basically on hold until the import changes and or plugin support goes in.
larry: *ping*
(In reply to comment #7) > Created an attachment (id=70896) [edit] > Update to apply to 20060814 CVS > > Quick-n-dirty update of the patch to apply to current CVS. I'll see if I can > clean it up to some acceptable state in the next couple of weeks. > Applied this patch to the dated CVS and got this: An unhandled exception was thrown: Object reference not set to an instance of an object in <0x0003c> ImportCommand:DoImport () in <0x00032> ImportCommand:DoImportFromIdleHandler () in <0x00037> (wrapper delegate-invoke) System.MulticastDelegate:invoke_bool () in <0x0002b> FSpot.Delay:HandleOperation () in <0x00037> (wrapper delegate-invoke) System.MulticastDelegate:invoke_bool () in <0x0002a> IdleProxy:Handler () in <0x00036> (wrapper native-to-managed) IdleProxy:Handler () in (unmanaged) 0xb7cc2bf1 in <0x00004> (wrapper managed-to-native) Gtk.Dialog:gtk_dialog_run (intptr) in <0x0001d> Gtk.Dialog:Run () in <0x0051a> ImportCommand:ImportFromDialog (PhotoStore) in <0x00050> MainWindow:HandleImportCommand (object,System.EventArgs) in <0x00041> (wrapper delegate-invoke) System.MulticastDelegate:invoke_void_object_EventArgs (object,System.EventArgs) in <0x00093> GLib.Signal:voidObjectCallback (intptr,intptr) in <0x00035> (wrapper native-to-managed) GLib.Signal:voidObjectCallback (intptr,intptr) in (unmanaged) 0xb647b422 in <0x00004> (wrapper managed-to-native) Gtk.Application:gtk_main () in <0x00007> Gtk.Application:Run () in <0x00007> Gnome.Program:Run () in <0x0063f> FSpot.Driver:Main (string[]) .NET Version: 1.1.4322.2032 Assembly Version Information: System.Xml (1.0.5000.0) libgphoto2-sharp (1.0.2491.13977) FlickrNet (1.1.0.0) gconf-sharp (2.8.0.0) pango-sharp (2.8.0.0) SemWeb (0.5.0.2) glade-sharp (2.8.0.0) gtkhtml-sharp (2.8.0.0) System.Data (1.0.5000.0) Mono.Data.SqliteClient (1.0.5000.0) gdk-sharp (2.8.0.0) gnome-vfs-sharp (2.8.0.0) dbus-sharp (0.60.0.0) System (1.0.5000.0) Mono.Posix (1.0.5000.0) atk-sharp (2.8.0.0) gtk-sharp (2.8.0.0) glib-sharp (2.8.0.0) gnome-sharp (2.8.0.0) f-spot (0.0.0.0) mscorlib (1.0.5000.0) Platform Information: Linux 2.6.15-26-386 i686 unknown GNU/Linux Disribution Information: [/etc/debian_version] testing/unstable [/etc/lsb-release] DISTRIB_ID=Ubuntu DISTRIB_RELEASE=6.06 DISTRIB_CODENAME=dapper DISTRIB_DESCRIPTION="Ubuntu 6.06 LTS"
Ignore the above- my suspicion is I improperly applied the patch. Will work on it some more.
Any word on this working in the new version? It was working at one point in time, it would be a shame if it fell by the way side.
Errm. Dear F-Spot developers: The version field always refers to an EXISTING version. "WISHLIST" is NOT a version. Please remove that.
Which version should an unversioned feature request point to then? And how can we quickly distinguish them? The WISHLIST version allows us to keep version requests in the bugzilla, while not cluttering up the rest of the views, such that we can find the real bugs between the stuff that might be here indefinitely. Is there a better way to go about this?
You can't file reports against versions that don't exist. :-) A feature request or bug report gets reported against an existing version (best of course is the latest version) where either the requested feature does not (yet) exist or the bug exists in. Wishlist means Severity = enhancement. And if it's unrealistic set the Priority to Low.
That's what we used to do and the end result was loads of ancient versions floating around with only feature requests. Hardly anything better than the non-existent WISHLIST version. While I agree that it's not 100% "correct", it's not that much worse either: these old versions aren't used nor maintained anyway and are in a sense as non-existent as WISHLIST. At least with WISHLIST, it doesn't give the false impression that the bug is in any way related to e.g. 0.5.3... Anyway, this discussion shouldn't go in this bug, let's used the mailing list in the future :-)
> loads of ancient versions floating around with only feature requests. You could use "Unspecified" for that. And if you know that those features are not implemented yet you can always mass-update them to a recent version. And if you run queries, exclude the enhancement severity. If there's a mailing list discussion, CC me. :-)
Import has been completely rewritten, so this won't work again. It should be *much* easier to build this now though.
Apologies that this wasn't reviewed in time btw. I wasn't involved back then, but right now I have instated a policy that patch review has super-high priority.
F-Spot has moved to https://github.com/f-spot/f-spot/issues If this Bugzilla ticket is still valid in a recent version of F-Spot, please feel free to post this topic as a ticket in the F-Spot project on GitHub. Closing this report as WONTFIX as part of Bugzilla Housekeeping as we are planning to shut down GNOME Bugzilla in favor of GNOME Gitlab.