After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 300965 - Please use a hyphen instead of an underscore, i.e "translator-credits".
Please use a hyphen instead of an underscore, i.e "translator-credits".
Status: RESOLVED FIXED
Product: gucharmap
Classification: Core
Component: general
unspecified
Other All
: Normal minor
: ---
Assigned To: Noah Levitt
Behdad Esfahbod
Depends on:
Blocks:
 
 
Reported: 2005-04-17 15:16 UTC by Vincent van Adrighem
Modified: 2006-01-21 18:28 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Here is a fix for this bug report (834 bytes, patch)
2005-07-22 19:08 UTC, Tommi Vainikainen
none Details | Review
Replace underscore with dash in translation credits string. (762 bytes, patch)
2005-11-28 09:08 UTC, Behnam Esfahbod
committed Details | Review

Description Vincent van Adrighem 2005-04-17 15:16:10 UTC
/gucharmap/gucharmap-window.c:319
msgid "translator_credits"

Other information:
Some translation tools check that messages which have access keys in the
source also have access keys in the translation, and barf otherwise.
Obviously those tools will mistake this underscore for an access key.
Comment 1 Tommi Vainikainen 2005-07-22 19:08:53 UTC
Created attachment 49590 [details] [review]
Here is a fix for this bug report
Comment 2 Behnam Esfahbod 2005-11-28 09:08:12 UTC
Created attachment 55303 [details] [review]
Replace underscore with dash in translation credits string.
Comment 3 Behdad Esfahbod 2005-11-28 09:20:50 UTC
Behnam, any reason the first patch is wrong?
Comment 4 Behnam Esfahbod 2005-11-28 11:02:12 UTC
It was just out of date.
Comment 5 Vincent van Adrighem 2005-12-21 11:46:31 UTC
And this patch works perfectly. Just applied it to current debian source.

Maybe you could do a search&replace on all po-files for this. It would be a clean update.
's/translator_credits/translator-credits/'
Comment 6 Behdad Esfahbod 2005-12-25 12:04:40 UTC
Complete patch with the po-files updates, tested and all needed.  I want somebody to blame when the flame comes on gnome-i18n about committing to somebody else's po-files :).
Comment 7 Vincent van Adrighem 2006-01-07 15:51:04 UTC
If you only patch the line in the po-files containing the "translator_credits", I will take full responsibility on the i18n list. But please announce the change on the list.
Comment 8 Behdad Esfahbod 2006-01-21 18:28:51 UTC
2006-01-21  Behdad Esfahbod  <behdad@gnome.org>

        * gucharmap/gucharmap-window.c, po/*.po: Replace "translator_credits"
        with "translator-credits". (bug #300965)