GNOME Bugzilla – Bug 300923
[PATCH] make ffdec_* elements use gst_pad_alloc_buffer
Last modified: 2005-04-18 09:51:48 UTC
This patch makes ffdec_* elements use gst_pad_alloc_buffer. I had to move the call to negotiate. I don't like to have it splitted for audio and video but the other solution (add a negotiated flag) was quite ugly. With this patch a pipeline like decodebin ! xvimagesink goes down from 44% cpu usage to 33% on my system.
Created attachment 45347 [details] [review] patch to enable _pad_alloc on ffdec elements
For video, you call gst_buffer_unref() on outbuf, which is only allocated afterwards. :). Other than that, good patch.
Created attachment 45349 [details] [review] don't call unref on a non allocated buffer
applied, thanks.