After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 300923 - [PATCH] make ffdec_* elements use gst_pad_alloc_buffer
[PATCH] make ffdec_* elements use gst_pad_alloc_buffer
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-libav
git master
Other Linux
: Normal normal
: 0.8.5
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2005-04-17 08:45 UTC by Luca Ognibene
Modified: 2005-04-18 09:51 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
patch to enable _pad_alloc on ffdec elements (1.59 KB, patch)
2005-04-17 08:47 UTC, Luca Ognibene
none Details | Review
don't call unref on a non allocated buffer (1.58 KB, patch)
2005-04-17 10:32 UTC, Luca Ognibene
none Details | Review

Description Luca Ognibene 2005-04-17 08:45:20 UTC
This patch makes ffdec_* elements use gst_pad_alloc_buffer. I had to move the
call to negotiate. I don't like to have it splitted for audio and video but the
other solution (add a negotiated flag) was quite ugly.
With this patch a pipeline like decodebin ! xvimagesink goes down from 44% cpu
usage to 33% on my system.
Comment 1 Luca Ognibene 2005-04-17 08:47:23 UTC
Created attachment 45347 [details] [review]
patch to enable _pad_alloc on ffdec elements
Comment 2 Ronald Bultje 2005-04-17 09:31:25 UTC
For video, you call gst_buffer_unref() on outbuf, which is only allocated
afterwards. :). Other than that, good patch.
Comment 3 Luca Ognibene 2005-04-17 10:32:48 UTC
Created attachment 45349 [details] [review]
don't call unref on a non allocated buffer
Comment 4 Ronald Bultje 2005-04-18 09:51:48 UTC
applied, thanks.